Bug 94366

Summary: Move transformFriendlyBoundingBox out of Range
Product: WebKit Reporter: Leandro Graciá Gil <leandrogracia>
Component: HTML EditingAssignee: Leandro Graciá Gil <leandrogracia>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric, rniwa, simon.fraser, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch rniwa: review+, rniwa: commit-queue+

Leandro Graciá Gil
Reported 2012-08-17 11:09:44 PDT
Bug 93111 introduced a new method in Range called transformFriendlyBoundingBox. However, these methods should be moved out of Range in order to attach as much as possible to the DOM specification. This patch moves this functionality to a static method in RenderView. It also updates the code making using of such method.
Attachments
Patch (7.05 KB, patch)
2012-08-17 11:39 PDT, Leandro Graciá Gil 		no flags
DetailsFormatted DiffDiff
Patch (7.16 KB, patch)
2012-08-20 14:21 PDT, Leandro Graciá Gil 		rniwa: review+
rniwa: commit-queue+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Leandro Graciá Gil
Comment 1 2012-08-17 11:39:07 PDT
Created attachment 159169 [details] Patch
Leandro Graciá Gil
Comment 2 2012-08-17 11:41:08 PDT
Comment on attachment 159169 [details] Patch I suggest using RenderObject instead of RenderView as it implements a very similar method called absoluteBoundingBoxRect.
Ryosuke Niwa
Comment 3 2012-08-17 16:52:31 PDT
I'd like to hear smfr's opinion here.
Simon Fraser (smfr)
Comment 4 2012-08-20 11:18:50 PDT
Comment on attachment 159169 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=159169&action=review Looks good. > Source/WebCore/rendering/RenderObject.h:714 > + static FloatRect absoluteBoundingBoxRectForRange(Range*); Can that be a const Range*?
Leandro Graciá Gil
Comment 5 2012-08-20 14:21:41 PDT
Created attachment 159519 [details] Patch
Leandro Graciá Gil
Comment 6 2012-08-20 14:22:02 PDT
Comment on attachment 159169 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=159169&action=review >> Source/WebCore/rendering/RenderObject.h:714 >> + static FloatRect absoluteBoundingBoxRectForRange(Range*); > > Can that be a const Range*? Fixed.
Ryosuke Niwa
Comment 7 2012-08-20 14:36:39 PDT
Comment on attachment 159519 [details] Patch I'll land this manually.
Ryosuke Niwa
Comment 8 2012-08-20 14:41:09 PDT
Committed r126074: <http://trac.webkit.org/changeset/126074>
Note You need to log in before you can comment on or make changes to this bug.