Bug 94329

Summary: [BlackBerry] Adapt to changes in the platform media player API
Product: WebKit Reporter: Robin Cao <robin.webkit>
Component: WebKit BlackBerryAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: eric.carlson, feature-media-reviews, mifenton, rwlbuis, staikos, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Other   
Attachments:
Description Flags
patch none

Robin Cao
Reported 2012-08-17 03:52:13 PDT
The platform now provides an abtract interface PlatformPlayer which roughly corresponds to WebKit's MediaPlayerPrivate. We need to adapt to these changes.
Attachments
patch (19.47 KB, patch)
2012-08-17 05:11 PDT, Robin Cao 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Robin Cao
Comment 1 2012-08-17 05:11:42 PDT
Created attachment 159094 [details] patch
Antonio Gomes
Comment 2 2012-08-17 07:14:58 PDT
Comment on attachment 159094 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=159094&action=review > Source/WebCore/platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:175 > - m_platformPlayer->cancelLoad(); > + if (m_platformPlayer) > + m_platformPlayer->cancelLoad(); I think this and all the other null checks are changes in the behavior. Why is that needed now?
Eric Carlson
Comment 3 2012-08-17 09:41:34 PDT
Comment on attachment 159094 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=159094&action=review This looks OK to me, but I know absolutely nothing about either the old or new platform player so I will let someone else give it a real review. >> Source/WebCore/platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:175 >> + m_platformPlayer->cancelLoad(); > > I think this and all the other null checks are changes in the behavior. Why is that needed now? Because m_platformPlayer is allocated in load rather than in the constructor?
Antonio Gomes
Comment 4 2012-08-17 10:08:10 PDT
Comment on attachment 159094 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=159094&action=review >>> Source/WebCore/platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:175 >>> + m_platformPlayer->cancelLoad(); >> >> I think this and all the other null checks are changes in the behavior. Why is that needed now? > > Because m_platformPlayer is allocated in load rather than in the constructor? Very reasonable.
WebKit Review Bot
Comment 5 2012-08-20 01:47:20 PDT
Comment on attachment 159094 [details] patch Clearing flags on attachment: 159094 Committed r126008: <http://trac.webkit.org/changeset/126008>
WebKit Review Bot
Comment 6 2012-08-20 01:47:23 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.