Bug 94319

Summary: [CMake] Add FindDBus.cmake and use it in the EFL port.
Product: WebKit Reporter: Raphael Kubo da Costa (:rakuco) <rakuco>
Component: Tools / TestsAssignee: Raphael Kubo da Costa (:rakuco) <rakuco>
Status: RESOLVED FIXED    
Severity: Normal CC: d-r, gyuyoung.kim, mxie, paroga, rwlbuis, tmpsantos, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
For landing none

Raphael Kubo da Costa (:rakuco)
Reported 2012-08-17 02:25:42 PDT
[CMake] Add FindDBus.cmake and use it in the EFL port.
Attachments
Patch (5.50 KB, patch)
2012-08-17 02:29 PDT, Raphael Kubo da Costa (:rakuco) 		no flags
DetailsFormatted DiffDiff
For landing (5.49 KB, patch)
2012-08-17 12:08 PDT, Raphael Kubo da Costa (:rakuco) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Raphael Kubo da Costa (:rakuco)
Comment 1 2012-08-17 02:29:01 PDT
Created attachment 159056 [details] Patch
Patrick R. Gansterer
Comment 2 2012-08-17 02:31:16 PDT
Comment on attachment 159056 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=159056&action=review > Source/cmake/FindDBus.cmake:32 > +FIND_PACKAGE(PkgConfig) > +PKG_CHECK_MODULES(PC_DBUS QUIET dbus-1) isn't there a way to do it without pkgconfig?
Raphael Kubo da Costa (:rakuco)
Comment 3 2012-08-17 02:38:06 PDT
(In reply to comment #2) > (From update of attachment 159056 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=159056&action=review > > > Source/cmake/FindDBus.cmake:32 > > +FIND_PACKAGE(PkgConfig) > > +PKG_CHECK_MODULES(PC_DBUS QUIET dbus-1) > > isn't there a way to do it without pkgconfig? Yes, the current one :-) pkg-config isn't required, and its values (when they do exist) are only used as hints.
Patrick R. Gansterer
Comment 4 2012-08-17 02:48:46 PDT
Comment on attachment 159056 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=159056&action=review >>> Source/cmake/FindDBus.cmake:32 >>> +PKG_CHECK_MODULES(PC_DBUS QUIET dbus-1) >> >> isn't there a way to do it without pkgconfig? > > Yes, the current one :-) pkg-config isn't required, and its values (when they do exist) are only used as hints. sorry, more "correct" question: is PKG_CHECK_MODULES defined always? -> i checked it myself and it is ;-) sorry for the noice
Daniel Bates
Comment 5 2012-08-17 11:58:56 PDT
Comment on attachment 159056 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=159056&action=review r=me > ChangeLog:15 > + Once we properly detect the EFL without pkg-config, that's going > + to break, so write a FindDBus.cmake to avoid that problem in the > + future. This sentence doesn't read well.
Daniel Bates
Comment 6 2012-08-17 12:00:13 PDT
Comment on attachment 159056 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=159056&action=review > ChangeLog:11 > + edbus's pkg-config information. Nit: edbus's => EDbus's
Raphael Kubo da Costa (:rakuco)
Comment 7 2012-08-17 12:08:54 PDT
Created attachment 159174 [details] For landing
Raphael Kubo da Costa (:rakuco)
Comment 8 2012-08-17 12:13:27 PDT
Committed r125924: <http://trac.webkit.org/changeset/125924>
Note You need to log in before you can comment on or make changes to this bug.