Summary: | [EFL] [WK2] Free Eina Strbuf with eina_strbuf_free() instead of eina_strbuf_string_free() | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Sudarsana Nagineni (babu) <naginenis> | ||||||||
Component: | WebKit EFL | Assignee: | Sudarsana Nagineni (babu) <naginenis> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | gyuyoung.kim, kenneth, lucas.de.marchi, webkit.review.bot | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Sudarsana Nagineni (babu)
2012-08-17 01:47:01 PDT
Created attachment 159051 [details]
Patch
Comment on attachment 159051 [details]
Patch
I have to trust you on that one, but it would be good if the changelog explained the difference
Comment on attachment 159051 [details]
Patch
Yes, LGTM. My bad. Thanks for fixing it.
Created attachment 159074 [details]
Patch
Updated changelog. Thanks for review Kenneth.
Comment on attachment 159074 [details] Patch Rejecting attachment 159074 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 ERROR: /mnt/git/webkit-commit-queue/Source/WebKit2/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/13511962 Created attachment 159083 [details]
Patch
Forgot to update reviewer name in changelog.
Comment on attachment 159083 [details] Patch Clearing flags on attachment: 159083 Committed r125888: <http://trac.webkit.org/changeset/125888> All reviewed patches have been landed. Closing bug. |