Bug 94312

Summary:

[EFL] [WK2] Free Eina Strbuf with eina_strbuf_free() instead of eina_strbuf_string_free()

Product:

WebKit

Reporter:

Sudarsana Nagineni (babu) <naginenis>

Component:

WebKit EFL

Assignee:

Sudarsana Nagineni (babu) <naginenis>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

gyuyoung.kim, kenneth, lucas.de.marchi, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	kenneth: review+
Patch	webkit.review.bot: commit-queue-
Patch	none

Sudarsana Nagineni (babu)

Reported 2012-08-17 01:47:01 PDT

String buffer must be freed with eina_strbuf_free() instead of eina_strbuf_string_free().

Attachments
Patch (1.75 KB, patch) 2012-08-17 02:08 PDT, Sudarsana Nagineni (babu)	kenneth: review+	Details Formatted Diff Diff
Patch (1.96 KB, patch) 2012-08-17 03:46 PDT, Sudarsana Nagineni (babu)	webkit.review.bot: commit-queue-	Details Formatted Diff Diff
Patch (2.00 KB, patch) 2012-08-17 04:12 PDT, Sudarsana Nagineni (babu)	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Sudarsana Nagineni (babu)

Comment 1 2012-08-17 02:08:27 PDT

Created attachment 159051 [details] Patch

Kenneth Rohde Christiansen

Comment 2 2012-08-17 02:15:40 PDT

Comment on attachment 159051 [details] Patch I have to trust you on that one, but it would be good if the changelog explained the difference

Chris Dumez

Comment 3 2012-08-17 02:49:00 PDT

Comment on attachment 159051 [details] Patch Yes, LGTM. My bad. Thanks for fixing it.

Sudarsana Nagineni (babu)

Comment 4 2012-08-17 03:46:39 PDT

Created attachment 159074 [details] Patch Updated changelog. Thanks for review Kenneth.

WebKit Review Bot

Comment 5 2012-08-17 03:48:57 PDT

Comment on attachment 159074 [details] Patch Rejecting attachment 159074 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 ERROR: /mnt/git/webkit-commit-queue/Source/WebKit2/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/13511962

Sudarsana Nagineni (babu)

Comment 6 2012-08-17 04:12:21 PDT

Created attachment 159083 [details] Patch Forgot to update reviewer name in changelog.

WebKit Review Bot

Comment 7 2012-08-17 05:33:32 PDT

Comment on attachment 159083 [details] Patch Clearing flags on attachment: 159083 Committed r125888: <http://trac.webkit.org/changeset/125888>

WebKit Review Bot

Comment 8 2012-08-17 05:33:37 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.