Bug 94262

Summary: Delete some dead code in RenderBox::computePercentageLogicalHeight
Product: WebKit Reporter: Ojan Vafai <ojan>
Component: New BugsAssignee: Ojan Vafai <ojan>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, hyatt, jamesr, jchaffraix, tony
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch tony: review+

Description Ojan Vafai 2012-08-16 16:05:51 PDT
Delete some dead code in RenderBox::computePercentageLogicalHeight
Comment 1 Ojan Vafai 2012-08-16 16:35:07 PDT
Created attachment 158940 [details]
Patch
Comment 2 Tony Chang 2012-08-16 18:06:30 PDT
Comment on attachment 158940 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=158940&action=review

> Source/WebCore/ChangeLog:9
> +        I'm pretty sure this is dead code. None of the layout tests hit this code,
> +        including the ones added in the original patch http://trac.webkit.org/changeset/10983.

Do we not hit this code because we hit an earlier case that does the same thing?
Comment 3 Ojan Vafai 2012-08-16 18:12:02 PDT
Comment on attachment 158940 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=158940&action=review

>> Source/WebCore/ChangeLog:9
>> +        including the ones added in the original patch http://trac.webkit.org/changeset/10983.
> 
> Do we not hit this code because we hit an earlier case that does the same thing?

No. The cases where we might in theory hit this code, we instead go through computePositionedLogicalHeight (i.e. never call computePercentageLogicalHeight).
Comment 4 Tony Chang 2012-08-16 18:25:01 PDT
Comment on attachment 158940 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=158940&action=review

>>> Source/WebCore/ChangeLog:9
>>> +        including the ones added in the original patch http://trac.webkit.org/changeset/10983.
>> 
>> Do we not hit this code because we hit an earlier case that does the same thing?
> 
> No. The cases where we might in theory hit this code, we instead go through computePositionedLogicalHeight (i.e. never call computePercentageLogicalHeight).

I would include this explanation in the ChangeLog.  Would also be good to say which test covers this.
Comment 5 Ojan Vafai 2012-08-17 14:46:36 PDT
Committed r125938: <http://trac.webkit.org/changeset/125938>