Bug 94257

Summary: [chromium] pepper plugins sometimes are shifted by 1 pixel.
Product: WebKit Reporter: yzshen
Component: Layout and RenderingAssignee: yzshen
Status: RESOLVED FIXED    
Severity: Normal CC: eric, parth.bhakta, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

yzshen
Reported 2012-08-16 15:21:45 PDT
Relevant bug reports on crbug.com: http://code.google.com/p/chromium/issues/detail?id=140577 http://code.google.com/p/chromium/issues/detail?id=138366 This is because RenderWidget truncates non-integer coordinates incorrectly. I will upload a CL very soon.
Attachments
Patch (1.80 KB, patch)
2012-08-16 16:12 PDT, yzshen 		no flags
DetailsFormatted DiffDiff
Patch (2.07 KB, patch)
2012-08-17 12:57 PDT, yzshen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
yzshen
Comment 1 2012-08-16 16:12:02 PDT
Created attachment 158933 [details] Patch
Levi Weintraub
Comment 2 2012-08-16 16:18:21 PDT
Comment on attachment 158933 [details] Patch The change looks good, but why no tests?
yzshen
Comment 3 2012-08-16 16:36:21 PDT
(In reply to comment #2) > (From update of attachment 158933 [details]) > The change looks good, but why no tests? Thanks for the suggestion, I will try to work out a test.
parth.bhakta
Comment 4 2012-08-16 23:14:13 PDT
I think this should be bumped in priority so it gets fixed in the latest stable release, the bug affects every flash plugin in Chrome. For example, in my current version of Chrome(21.0.1180.79)/Flash(11.3.300.271) , I cannot use any flash video chat site. Sites like airtime, tinychat, etc. do not work since I can't click "Allow" in Flash. Also if I ever try to access Flash settings, I cannot modify anything and I am stuck and cannot exit.
yzshen
Comment 5 2012-08-17 12:57:44 PDT
Created attachment 159184 [details] Patch
yzshen
Comment 6 2012-08-17 13:02:45 PDT
Hi, Levi. I looked into adding a test. However, this issue only affects the optimized rendering code path for Pepper plugins (PluginInstance::GetBitmapForOptimizedPluginPaint). I didn't add a test because we don't have Pepper plugin tests in WebKit. I have updated the ChangeLog to explain the reason. Is it okay to submit this without a test? Thanks!
Levi Weintraub
Comment 7 2012-08-20 10:09:18 PDT
Comment on attachment 159184 [details] Patch Okay.
WebKit Review Bot
Comment 8 2012-08-20 11:01:56 PDT
Comment on attachment 159184 [details] Patch Clearing flags on attachment: 159184 Committed r126042: <http://trac.webkit.org/changeset/126042>
WebKit Review Bot
Comment 9 2012-08-20 11:02:00 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.