Bug 94205

Summary: The relationship between abstract values and structure transition watchpoints should be rationalized
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, fpizlo, ggaren, mhahnenberg, msaboff, oliver, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 94201, 94408, 94412    
Bug Blocks: 91933    
Attachments:
Description Flags
work in progress
none
almost there
webkit-ews: commit-queue-
the patch ggaren: review+

Filip Pizlo
Reported 2012-08-16 01:18:03 PDT
And this rationalization should be used to enable automatic conversion of structure checks into watchpoints as appropriate.
Attachments
work in progress (52.05 KB, patch)
2012-08-16 01:22 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
almost there (54.27 KB, patch)
2012-08-16 19:09 PDT, Filip Pizlo 		webkit-ews: commit-queue-
DetailsFormatted DiffDiff
the patch (59.86 KB, patch)
2012-08-17 00:31 PDT, Filip Pizlo 		ggaren: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2012-08-16 01:22:03 PDT
Created attachment 158746 [details] work in progress
Filip Pizlo
Comment 2 2012-08-16 19:09:18 PDT
Created attachment 158976 [details] almost there It looks like it's working but I still need to do more perf tests.
Early Warning System Bot
Comment 3 2012-08-16 19:59:15 PDT
Comment on attachment 158976 [details] almost there Attachment 158976 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/13511820
Early Warning System Bot
Comment 4 2012-08-16 20:31:01 PDT
Comment on attachment 158976 [details] almost there Attachment 158976 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/13520265
Filip Pizlo
Comment 5 2012-08-16 22:28:05 PDT
(In reply to comment #4) > (From update of attachment 158976 [details]) > Attachment 158976 [details] did not pass qt-wk2-ews (qt): > Output: http://queues.webkit.org/results/13520265 Looks like I still have to make 32-bit changes. Will do so soon; first I want to test that the 64-bit part is at least perf-neutral.
Filip Pizlo
Comment 6 2012-08-17 00:31:19 PDT
Created attachment 159026 [details] the patch
WebKit Review Bot
Comment 7 2012-08-17 00:35:46 PDT
Attachment 159026 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/JavaScriptCore/dfg/DFGAbstractValue.h:247: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] Total errors found: 1 in 18 files If any of these errors are false positives, please file a bug against check-webkit-style.
Geoffrey Garen
Comment 8 2012-08-17 15:22:23 PDT
Comment on attachment 159026 [details] the patch r=me
Filip Pizlo
Comment 9 2012-08-19 23:14:22 PDT
Landed in http://trac.webkit.org/changeset/125999
Note You need to log in before you can comment on or make changes to this bug.