Bug 94192

Summary: REGRESSION(r119705): Causing crash on ClusterFuzz due to incorrect layout ordering change (Requested by inferno-sec on #webkit).
Product: WebKit Reporter: WebKit Review Bot <webkit.review.bot>
Component: New BugsAssignee: WebKit Review Bot <webkit.review.bot>
Status: RESOLVED WONTFIX    
Severity: Normal CC: inferno, rniwa, shinyak
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 94206    
Bug Blocks: 66120    
Attachments:
Description Flags
ROLLOUT of r119705 none

WebKit Review Bot
Reported 2012-08-16 00:02:25 PDT
http://trac.webkit.org/changeset/119705 broke the build: Causing crash on ClusterFuzz due to incorrect layout ordering change (Requested by inferno-sec on #webkit). This is an automatic bug report generated by the sheriff-bot. If this bug report was created because of a flaky test, please file a bug for the flaky test (if we don't already have one on file) and dup this bug against that bug so that we can track how often these flaky tests case pain. "Only you can prevent forest fires." -- Smokey the Bear
Attachments
ROLLOUT of r119705 (4.05 KB, patch)
2012-08-16 00:03 PDT, WebKit Review Bot 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
WebKit Review Bot
Comment 1 2012-08-16 00:03:04 PDT
Created attachment 158725 [details] ROLLOUT of r119705 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the rollout will be successful. This process takes approximately 15 minutes. If you would like to land the rollout faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID where ATTACHMENT_ID is the ID of this attachment.
Abhishek Arya
Comment 2 2012-08-16 00:06:24 PDT
Comment on attachment 158725 [details] ROLLOUT of r119705 Clearing flags on attachment: 158725 Committed r125751: <http://trac.webkit.org/changeset/125751>
Abhishek Arya
Comment 3 2012-08-16 00:06:27 PDT
All reviewed patches have been landed. Closing bug.
Ryosuke Niwa
Comment 4 2012-08-16 01:39:18 PDT
What!? I don't think rolling out this patch is a good idea. And who did make this decision and why was this not reviewed?
WebKit Review Bot
Comment 5 2012-08-16 01:45:38 PDT
Re-opened since this is blocked by 94206
Ryosuke Niwa
Comment 6 2012-08-16 01:48:46 PDT
Please don't roll out a 2-month old commit like this without consulting the author & the reviewer.
Alexey Proskuryakov
Comment 7 2012-08-16 09:36:54 PDT
We still need to fix the crash seen by ClusterFuzz though. Is there another bug tracking that now?
Abhishek Arya
Comment 8 2012-08-16 09:38:22 PDT
(In reply to comment #7) > We still need to fix the crash seen by ClusterFuzz though. Is there another bug tracking that now? cced you on https://bugs.webkit.org/show_bug.cgi?id=91325.
Note You need to log in before you can comment on or make changes to this bug.