Summary: | clipboardwin compile error for win64 | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Alex Christensen <alex.christensen> | ||||
Component: | WebCore Misc. | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | bfulgham, roger_fong | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | Windows 7 | ||||||
Attachments: |
|
Description
Alex Christensen
2012-08-15 10:51:48 PDT
Created attachment 158592 [details]
Patch
Comment on attachment 158592 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=158592&action=review Looks fine to me (and the EWS). Please revise the ChangeLog notes and I think we are ready to land/ > Source/WebCore/ChangeLog:5 > + I think you should include your helpful explanation here: "The clipboard utilities code uses std::min with one unsigned int parameter and one size_t parameter. This causes a problem when compiling for 64-bit windows because the two types are not the same size. To resolve this issue, we specify the template type as the type the return value is being cast into." Not only that, but my patch is missing my changes to ClipboardWin.cpp. Bad news: my computer just died, and I'm just about to change jobs, so it will be a while (~4 months) before I can properly patch this. If someone else wants to, be my guest. Sorry. Comment on attachment 158592 [details]
Patch
R+ for content. I'm adding the text I asked for in the ChangeLog while landing.
Committed r135763: <http://trac.webkit.org/changeset/135763> |