Bug 94124 – clipboardwin compile error for win64

• Component: WebCore Misc.
• Status: RESOLVED FIXED

[Alex Christensen]

There are a few places in the clipboard utilities code that use std::min with an unsigned int parameter and a size_t parameter, which doesn't cause a problem when compiling for 32-bit windows, but it does cause a problem when compiling for 64-bit windows.  To resolve this issue, I specify the template type as the type the return value is being cast into.

https://github.com/achristensen07/webkit64prep

patch coming soon

[Alex Christensen]

Created attachment 158592 [details]
Patch

[Brent Fulgham]

Comment on attachment 158592 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=158592&action=review

Looks fine to me (and the EWS).  Please revise the ChangeLog notes and I think we are ready to land/

> Source/WebCore/ChangeLog:5
> +

I think you should include your helpful explanation here:

"The clipboard utilities code uses std::min with one unsigned int parameter and one size_t parameter. This causes a problem when compiling for 64-bit windows because the two types are not the same size.  To resolve this issue, we specify the template type as the type the return value is being cast into."

[Alex Christensen]

Not only that, but my patch is missing my changes to ClipboardWin.cpp.

Bad news: my computer just died, and I'm just about to change jobs, so it will be a while (~4 months) before I can properly patch this.  If someone else wants to, be my guest.  Sorry.

[Brent Fulgham]

Comment on attachment 158592 [details]
Patch

R+ for content. I'm adding the text I asked for in the ChangeLog while landing.

[Brent Fulgham]

Committed r135763: <http://trac.webkit.org/changeset/135763>