Summary: | VoidCallback should not be a special snowflake | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Csaba Osztrogonác <ossy> | ||||||||||
Component: | New Bugs | Assignee: | Adam Barth <abarth> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | abarth, dglazkov, eric, gyuyoung.kim, haraken, japhet, ojan, ossy, peter+ews, rakuco, webkit.review.bot, zan | ||||||||||
Priority: | P2 | Keywords: | Qt, QtTriaged | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | All | ||||||||||||
OS: | All | ||||||||||||
Bug Depends on: | |||||||||||||
Bug Blocks: | 27640, 79666 | ||||||||||||
Attachments: |
|
Description
Csaba Osztrogonác
2012-08-15 09:04:11 PDT
You can easily reproduce it on Qt: Tools/Scripts/old-run-webkit-tests storage/websql/database-lock-after-reload.html --iterations 100 --singly 32 test cases (32%) succeeded 68 test cases (68%) had incorrect layout dhcp-172-31-55-91:abarth-webkit abarth$ Tools/Scripts/run-webkit-tests --debug storage/websql/database-lock-after-reload.html --iterations 1000 Using port 'mac-future' Test configuration: <future, x86_64, debug> Placing test results in None Baseline search path: mac -> generic Using Debug build Pixel tests disabled Regular timeout: 35000, slow test timeout: 175000 Command line: /Users/abarth/git/abarth-webkit/WebKitBuild/Debug/DumpRenderTree - Found 1 test; running 1000 (1000 times each: --repeat-each=1 --iterations=1000), skipping -999. Running 1 DumpRenderTree over 1 shard. [233/1000] storage/websql/database-lock-after-reload.html failed unexpectedly (text diff) [518/1000] storage/websql/database-lock-after-reload.html failed unexpectedly (text diff) [551/1000] storage/websql/database-lock-after-reload.html failed unexpectedly (text diff) [684/1000] storage/websql/database-lock-after-reload.html failed unexpectedly (text diff) Retrying 1 unexpected failure(s) ... Running 1 DumpRenderTree over 1 shard. 996 tests ran as expected, 4 didn't: Unexpected flakiness: text failures (1) storage/websql/database-lock-after-reload.html = TEXT PASS --- /Users/abarth/git/abarth-webkit/WebKitBuild/Debug/layout-test-results/storage/websql/database-lock-after-reload-expected.txt +++ /Users/abarth/git/abarth-webkit/WebKitBuild/Debug/layout-test-results/storage/websql/database-lock-after-reload-actual.txt @@ -1,3 +1 @@ -Inserting some data -Test part 2 Complete Looks like it's flaky on apple-mac as well, but much less so. http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20-%20webkit.org&tests=storage%2Fwebsql%2Fdatabase-lock Stating the obvious, at least for the Qt and GTK ports, it's only flaky in the release builds. > Stating the obvious, at least for the Qt and GTK ports, it's only flaky in the release builds.
Oh! Thanks for stating that. It's wasn't obvious to me! :)
Ok. It's much flakier release, even on apple-mac 88 tests ran as expected, 12 didn't: I understand the issue. Looking for the right fix. Created attachment 158654 [details]
Patch
Comment on attachment 158654 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=158654&action=review LGTM. Except the XCode oddity of course. > Source/WebCore/WebCore.xcodeproj/project.pbxproj:1963 > + 7C522D4C15B478B2009B7C95 /* (null) in Headers */ = {isa = PBXBuildFile; settings = {ATTRIBUTES = (Private, ); }; }; This looks wrong. > Source/WebCore/WebCore.xcodeproj/project.pbxproj:23634 > + 7C522D4C15B478B2009B7C95 /* (null) in Headers */, This also looks wrong. Comment on attachment 158654 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=158654&action=review > Source/WebCore/Modules/filesystem/SyncCallbackHelper.h:100 > + virtual bool handleEvent() OVERRIDE? (In reply to comment #11) > (From update of attachment 158654 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=158654&action=review > > > Source/WebCore/Modules/filesystem/SyncCallbackHelper.h:100 > > + virtual bool handleEvent() > > OVERRIDE? I actually had this locally but removed it when uploading. :) Created attachment 158656 [details]
Patch for landing
Let's give the EWS a look before landing. Comment on attachment 158656 [details] Patch for landing Attachment 158656 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13503799 Comment on attachment 158656 [details] Patch for landing Attachment 158656 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/13517147 Comment on attachment 158656 [details] Patch for landing Attachment 158656 [details] did not pass cr-android-ews (chromium-android): Output: http://queues.webkit.org/results/13514184 Created attachment 158666 [details]
Patch
Comment on attachment 158666 [details] Patch Attachment 158666 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13508408 Created attachment 158673 [details]
Patch
Comment on attachment 158673 [details] Patch Clearing flags on attachment: 158673 Committed r125745: <http://trac.webkit.org/changeset/125745> All reviewed patches have been landed. Closing bug. |