Bug 94057

Summary:

Allow blocking of Web SQL databases in third-party contexts

Product:

WebKit

Reporter:

Vicki Pfau <jeffrey+webkit>

Component:

WebCore Misc.

Assignee:

Vicki Pfau <jeffrey+webkit>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, atwilson

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	abarth: review+

Vicki Pfau

Reported 2012-08-14 18:32:27 PDT

Add a method for blocking Web SQL databases in a third-party context like was added for localStorage in bug #93390 <rdar://problem/11948659>

Attachments
Patch (8.94 KB, patch) 2012-08-14 18:58 PDT, Vicki Pfau	abarth: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Vicki Pfau

Comment 1 2012-08-14 18:58:34 PDT

Created attachment 158476 [details] Patch

Vicki Pfau

Comment 2 2012-08-14 19:00:36 PDT

This patch ONLY covers creation from a Document context. The web worker case is much more intricate (especially for shared workers), and I don't believe that the workers currently have enough information at the time of invoking openDatabase to be able to support this. I'm currently trying to figure out the best way to pipe that information down into the worker.

Adam Barth

Comment 3 2012-08-14 22:27:39 PDT

Comment on attachment 158476 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=158476&action=review > Source/WebCore/page/SecurityOrigin.cpp:400 > + if (!topOrigin) > + return true; Can you add a FIXME comment about workers? We don't want to have this branch here forever, right?

Vicki Pfau

Comment 4 2012-08-15 19:15:03 PDT

Committed r125736: <http://trac.webkit.org/changeset/125736>

Vicki Pfau

Comment 5 2012-08-15 19:21:09 PDT

Followup bugs filed at https://bugs.webkit.org/show_bug.cgi?id=94170 and https://bugs.webkit.org/show_bug.cgi?id=94171

Note You need to log in before you can comment on or make changes to this bug.