Bug 94000

Summary: LayoutUnit::epsilon shouldn't be necessary to place floats
Product: WebKit Reporter: Levi Weintraub <leviw>
Component: Layout and RenderingAssignee: Emil A Eklund <eae>
Status: RESOLVED FIXED    
Severity: Normal CC: eae, eric, leviw, ojan.autocc, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Levi Weintraub 2012-08-14 10:48:55 PDT 
Currently, to get float placement correct, we need to have an epsilon tolerance in RenderBlock::computeLogicalLocationForFloat for the width of the line to fit them on. This really shouldn't be necessary, and probably indicates we're losing precision elsewhere.

Removing the epsilon makes it easy to identify test cases already in LayoutTests.
Comment 1 Emil A Eklund 2013-02-14 15:36:42 PST 
Created attachment 188438 [details]
Patch
Comment 2 Levi Weintraub 2013-02-19 10:58:35 PST 
Comment on attachment 188438 [details]
Patch

Great!
Comment 3 WebKit Review Bot 2013-02-19 11:02:17 PST 
Comment on attachment 188438 [details]
Patch

Clearing flags on attachment: 188438

Committed r143357: <http://trac.webkit.org/changeset/143357>
Comment 4 WebKit Review Bot 2013-02-19 11:02:22 PST 
All reviewed patches have been landed.  Closing bug.