Bug 93980 – [WK2] Implement testRunner.setUseDeferredFrameLoading

• Component: Tools / Tests
• Status: NEW

[Sergio Villar Senin]

Needed by http/tests/appcache/load-from-appcache-defer-resume-crash.html

[Martin Robinson]

Does this apply to all ports or only to GTK+. If it's for all ports, perhaps we should remove the "[GTK]" tag.

[Sergio Villar Senin]

(In reply to comment #1)
> Does this apply to all ports or only to GTK+. If it's for all ports, perhaps we should remove the "[GTK]" tag.

Yep you're right

[Zoltan Nyul]

Created attachment 173585 [details]
patch

I added the setDeferredLoading method to the idl and TestRunner class, but the implementation would be just adding a timer for the mainloop like in the wk1 mac port, but the InjectedBundle is already asynchronous so i think there's no need for extra timers.

[Benjamin Poulain]

Comment on attachment 173585 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=173585&action=review

Thank you for looking into this.

> LayoutTests/platform/efl-wk2/TestExpectations:-199
> -# testRunner.setUseDeferredFrameLoading() is not implemented in WK2. Skipped so it does not generate PNG results.
> -webkit.org/b/93980 http/tests/appcache/load-from-appcache-defer-resume-crash.html [ Skip ]
> -

What about gtk-wk2?

> Tools/WebKitTestRunner/InjectedBundle/TestRunner.h:116
> +    // The InjectedBundle is already asynchronous so we don't need to implement it
> +    void setUseDeferredFrameLoading(bool) { }

Doing that would be wrong. Any future test that would do "setUseDeferredFrameLoading(false)" would use an unimplemented feature.
(What you could have done instead is rename the method so that it can only be set. E.g. forceDeferredFrameLoading().)

I also think not doing anything is probably wrong. WebPage seems to have an API for deferredFrameLoading: WebPage::setDefersLoading().