Bug 93973

Summary:

[WK2][GTK] Fullscreen tests timing out in bots

Product:

WebKit

Reporter:

Sergio Villar Senin <svillar>

Component:

WebKitGTK

Assignee:

Zan Dobersek <zan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

mrobinson, pnormand, spena, svillar, zan

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Sergio Villar Senin

Reported 2012-08-14 09:12:42 PDT

Right now these ones: fullscreen/anonymous-block-merge-crash.html fullscreen/full-screen-crash-offsetLeft.html fullscreen/full-screen-iframe-without-allow-attribute-allowed-from-parent.html fullscreen/full-screen-line-boxes-crash.html fullscreen/full-screen-render-inline.html fullscreen/parent-flow-inline-with-block-child.html fullscreen/full-screen-keyboard-disabled.html fullscreen/full-screen-request.html fullscreen/full-screen-cancel.html fullscreen/full-screen-stacking-context.html fullscreen/full-screen-iframe-zIndex.html fullscreen/full-screen-remove-ancestor-after.html fullscreen/full-screen-remove-sibling.html fullscreen/full-screen-iframe-legacy.html fullscreen/video-specified-size.html fullscreen/full-screen-remove-children.html fullscreen/full-screen-placeholder.html fullscreen/full-screen-css.html fullscreen/full-screen-zIndex.html fullscreen/full-screen-remove-ancestor.html fullscreen/video-controls-override.html fullscreen/video-controls-timeline.html fullscreen/full-screen-iframe-allowed.html fullscreen/full-screen-twice.html fullscreen/full-screen-remove.html fullscreen/full-screen-zIndex-after.html

Attachments
Patch (5.81 KB, patch) 2012-10-19 06:26 PDT, Zan Dobersek	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Martin Robinson

Comment 1 2012-08-14 09:13:54 PDT

CCing Fullscreen Master Z.

Philippe Normand

Comment 2 2012-08-15 06:09:56 PDT

Might be related with bug 93525

Zan Dobersek

Comment 3 2012-10-19 05:44:29 PDT

Huh, the feature defines packed in webcore_cppflags aren't passed to either WKTR or the injected bundle library, so there's basically no fullscreen support compiled into WKTR.

Zan Dobersek

Comment 4 2012-10-19 06:26:15 PDT

Created attachment 169609 [details] Patch

Zan Dobersek

Comment 5 2012-10-19 08:22:31 PDT

Comment on attachment 169609 [details] Patch Clearing flags on attachment: 169609 Committed r131902: <http://trac.webkit.org/changeset/131902>

Zan Dobersek

Comment 6 2012-10-19 08:22:35 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.