beginElement() does not observe updated animation attributes

• Component: SVG
• Status: RESOLVED FIXED

[Florin Malita]

Created attachment 158343 [details]
Circle should move left-to-right, then right-to-left

If an expired animation's attributes are updated programmatically and then the animation is restarted using beginElement(), the new values are ignored.

In the attached test, the green circle should animate left-to-right, then right-to-left. Instead, it animates left-to-right twice.

A workaround is to update the 'dur' attribute.

Chromium issue: http://code.google.com/p/chromium/issues/detail?id=141793

[Florin Malita]

The 'from', 'to' & 'by' attributes are not claimed (isSupportedAttribute) by any of the SVGSMILElement descendants, hence updates are ignored.

Patch coming soon.

[Florin Malita]

Created attachment 158394 [details]
Patch

[Dirk Schulze]

Comment on attachment 158394 [details]
Patch

I don't think that this approach is correct. You make these attributes animatable, but they aren't from the spec. point of view.

[Florin Malita]

(In reply to comment #3)
> (From update of attachment 158394 [details])
> I don't think that this approach is correct. You make these attributes animatable, but they aren't from the spec. point of view.

Hm, not sure I understand: why are you saying the patch makes these animatable? AFAICT, isSupportedAttribute() == true doesn't mean the attribute is animatable - am I missing something?

Looking at both SVG & SMIL specs, from/to/by appear to be defined at the same level as begin/end/dur/... - which are currently listed in SVGSMILElement::isSupportedAttribute().

[Dirk Schulze]

Comment on attachment 158394 [details]
Patch

Sorry, my fault. Mixed it up with something different :(.

[WebKit Review Bot]

Comment on attachment 158394 [details]
Patch

Clearing flags on attachment: 158394

Committed r125608: <http://trac.webkit.org/changeset/125608>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.