Bug 9394

Summary: Fix no-SVG build
Product: WebKit Reporter: David Kilzer (:ddkilzer) <ddkilzer>
Component: SVGAssignee: David Kilzer (:ddkilzer) <ddkilzer>
Status: RESOLVED FIXED    
Severity: Normal CC: mrowe
Priority: P2    
Version: 420+   
Hardware: Mac   
OS: OS X 10.4   
URL: http://build.webkit.org/
Attachments:
Description Flags
Patch v1 darin: review+

David Kilzer (:ddkilzer)
Reported 2006-06-10 13:53:26 PDT
The no-SVG build has been broken for a while. I have a patch to fix it. My only question is whether it would have been better to use the module value ("svg") to disable SVG support in generated files (in WebCore/bindings/scripts/CodeGeneratorJS.pm) instead of setting "Conditional=SVG" in all of the IDL files.
Attachments
Patch v1 (71.43 KB, patch)
2006-06-10 14:00 PDT, David Kilzer (:ddkilzer) 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
David Kilzer (:ddkilzer)
Comment 1 2006-06-10 14:00:56 PDT
Created attachment 8799 [details] Patch v1 Fix no-svg build. Tested on normal build as well.
Darin Adler
Comment 2 2006-06-11 16:30:04 PDT
Comment on attachment 8799 [details] Patch v1 r=me
David Kilzer (:ddkilzer)
Comment 3 2006-06-11 16:54:12 PDT
Committed revision 14815.
Note You need to log in before you can comment on or make changes to this bug.