Bug 93926 – [BlackBerry] Assertion failure in AppCacheGroup

• Component: WebKit BlackBerry
• Status: RESOLVED FIXED

[George Staikos]

Program terminated with signal 11, Segmentation fault.
#0  0x7ca01e26 in WebCore::mimeTypeFromDataURL (url=...) at
webkit/Source/WebCore/platform/KURL.cpp:1916
1916        ASSERT(protocolIs(url, "data"));
(gdb) where
#0  0x7ca01e26 in WebCore::mimeTypeFromDataURL (url=...) at
webkit/Source/WebCore/platform/KURL.cpp:1916
#1  0x7c905386 in WebCore::ApplicationCacheGroup::createResourceHandle
(this=0x1d41100, url=..., newestCachedResource=0x0)
    at
webkit/Source/WebCore/loader/appcache/ApplicationCacheGroup.cpp:513

In release mode this code should behave properly, so the fix is to just short circuit the data url decode if it isn't a data url.

[George Staikos]

Created attachment 158197 [details]
Patch to avoid the assertion failure

[Rob Buis]

Comment on attachment 158197 [details]
Patch to avoid the assertion failure

View in context: https://bugs.webkit.org/attachment.cgi?id=158197&action=review

Looks good, but I think the ChangeLog needs to be cleaned up before landing.

> Source/WebCore/ChangeLog:5
> +        change.

This seems to be the description part. I advise to stick to bug title here ("[BlackBerry] Assertion failure in AppCacheGroup") and move/merge above lines below Reviewed by.

[George Staikos]

Created attachment 158326 [details]
Updated patch

[WebKit Review Bot]

Comment on attachment 158326 [details]
Updated patch

Rejecting attachment 158326 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

ERROR: /mnt/git/webkit-commit-queue/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://queues.webkit.org/results/13491620

[George Staikos]

Created attachment 158327 [details]
One last try

Sigh.  Save first, attach second.  Repeat.

[WebKit Review Bot]

Comment on attachment 158327 [details]
One last try

Rejecting attachment 158327 [details] from commit-queue.

New failing tests:
animations/suspend-resume-animation-events.html
Full output: http://queues.webkit.org/results/13501260

[WebKit Review Bot]

Created attachment 158345 [details]
Archive of layout-test-results from gce-cq-01

The attached test failures were seen while running run-webkit-tests on the commit-queue.
Bot: gce-cq-01  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid

[WebKit Review Bot]

Comment on attachment 158327 [details]
One last try

Clearing flags on attachment: 158327

Committed r125570: <http://trac.webkit.org/changeset/125570>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.