Bug 93909

Summary: Rebaseline fast/box-sizing/box-sizing.html and compositing/overflow/clip-descendents.html.
Product: WebKit Reporter: Roger Fong <roger_fong>
Component: Tools / TestsAssignee: Roger Fong <roger_fong>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, robert, thorton, webkit.review.bot
Priority: P2 Keywords: LayoutTestFailure
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
thorton: review-, thorton: commit-queue-
patch none

Roger Fong
Reported 2012-08-13 16:39:06 PDT
As per https://bugs.webkit.org/show_bug.cgi?id=92904 rebaselining tests for Apple-mac and windows ports. I rebaselined using expected results on Windows which in this case should be the same as mac but I don't have a convenient setup to actually test that with...
Attachments
patch (4.94 KB, patch)
2012-08-13 16:45 PDT, Roger Fong 		thorton: review-
thorton: commit-queue-
DetailsFormatted DiffDiff
patch (5.90 KB, patch)
2012-08-14 13:25 PDT, Roger Fong 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Roger Fong
Comment 1 2012-08-13 16:45:18 PDT
Created attachment 158144 [details] patch
Roger Fong
Comment 2 2012-08-14 12:01:39 PDT
Hi Robert, I just rebaselined the apple port tests. Can you quickly review it? Shouldn't be anything surprising in there. Thanks!
Robert Hogan
Comment 3 2012-08-14 12:26:21 PDT
(In reply to comment #2) > Hi Robert, > I just rebaselined the apple port tests. > Can you quickly review it? Shouldn't be anything surprising in there. > Thanks! They look good to me.
Tim Horton
Comment 4 2012-08-14 12:48:50 PDT
Since you're rebaselining the mac results, you should take it out of TestExpectations. Since you can't run the tests there, we'll keep an eye and make sure they pass after you land.
Roger Fong
Comment 5 2012-08-14 13:25:00 PDT
Created attachment 158403 [details] patch
WebKit Review Bot
Comment 6 2012-08-14 14:24:14 PDT
Comment on attachment 158403 [details] patch Clearing flags on attachment: 158403 Committed r125606: <http://trac.webkit.org/changeset/125606>
WebKit Review Bot
Comment 7 2012-08-14 14:24:17 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.