Bug 93866

Summary: [BlackBerry] Queue spellcheck requests with char-count limitations
Product: WebKit Reporter: Nima Ghanavatian <nima.ghanavatian>
Component: WebKit BlackBerryAssignee: Nima Ghanavatian <nima.ghanavatian>
Status: RESOLVED FIXED    
Severity: Normal CC: mifenton, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Nima Ghanavatian
Reported 2012-08-13 10:49:29 PDT
We would like to have shorter limitations than simply by-paragraph for spellcheck requests. Also, we should spellcheck the entire field on focus.
Attachments
Patch (16.57 KB, patch)
2012-08-14 08:08 PDT, Nima Ghanavatian 		no flags
DetailsFormatted DiffDiff
Patch (16.37 KB, patch)
2012-08-14 11:38 PDT, Nima Ghanavatian 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Nima Ghanavatian
Comment 1 2012-08-14 08:08:36 PDT
Created attachment 158335 [details] Patch
Rob Buis
Comment 2 2012-08-14 11:12:30 PDT
Comment on attachment 158335 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=158335&action=review Looks good, some minor issues to fix. > Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp:789 > + BlackBerry::Platform::StopWatch m_timer; We generally do not use m_ for static local vars. > Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp:796 > + Frame* frame = element->document()->frame(); Could element->document() be null? > Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp:857 > + // If total block text is under the limitted amount, send the entire chunk. limited I think. > Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp:899 > + RefPtr<Range> rangeForSpellChecking = 0; I dont think the = 0 is needed, should be the default.
Nima Ghanavatian
Comment 3 2012-08-14 11:38:06 PDT
Created attachment 158383 [details] Patch
Rob Buis
Comment 4 2012-08-14 12:03:05 PDT
Comment on attachment 158383 [details] Patch Looks good.
WebKit Review Bot
Comment 5 2012-08-14 13:45:29 PDT
Comment on attachment 158383 [details] Patch Clearing flags on attachment: 158383 Committed r125598: <http://trac.webkit.org/changeset/125598>
WebKit Review Bot
Comment 6 2012-08-14 13:45:32 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.