Summary: | [Qt] QNX build fails due to reference to MADV_FREE_REUSE and MADV_FREE_REUSABLE | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Milian Wolff <milian.wolff> | ||||||
Component: | WebKit Qt | Assignee: | Milian Wolff <milian.wolff> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | hausmann, laszlo.gombos, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 74040 | ||||||||
Attachments: |
|
Description
Milian Wolff
2012-08-13 07:22:34 PDT
Created attachment 157991 [details]
Patch
Comment on attachment 157991 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=157991&action=review > Source/WTF/wtf/Platform.h:483 > -#if PLATFORM(BLACKBERRY) > +#if PLATFORM(BLACKBERRY) || OS(QNX) Wouldn't it be simpler to use just OS(QNX) instead of PLATFORM(BLACKBERRY) || OS(QNX) ? Isn't the latter set when the former is true? As far as I understand https://bugs.webkit.org/show_bug.cgi?id=74040#c15 you are right, I'll adapt the patch accordingly. Cheers Created attachment 158287 [details]
Patch
Comment on attachment 158287 [details] Patch Clearing flags on attachment: 158287 Committed r125553: <http://trac.webkit.org/changeset/125553> All reviewed patches have been landed. Closing bug. |