Bug 9384

Summary: WebView's initWithCoder: does not set useBackForwardList correctly
Product: WebKit Reporter: Graham Dennis <Graham.Dennis>
Component: WebKit Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 420+   
Hardware: Mac   
OS: OS X 10.4   
Attachments:
Description Flags
patch sullivan: review+

Graham Dennis
Reported 2006-06-10 01:04:22 PDT
When init'ing with a keyed coder, the value of useBackForwardList in WebView's _private ivar is set on line 1608, but this value is reset on line 1630 by the function's local variable useBackForwardList. Instead of setting the value of useBackForwardList in the _private ivar on line 1608, the local variable should be set, which in turn sets the value in the _private ivar. I will attach a patch in a moment.
Attachments
patch (1.37 KB, patch)
2006-06-10 01:08 PDT, Graham Dennis 		sullivan: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Graham Dennis
Comment 1 2006-06-10 01:08:47 PDT
Created attachment 8793 [details] patch
John Sullivan
Comment 2 2006-06-10 06:29:08 PDT
Comment on attachment 8793 [details] patch Good catch. I'm surprised the method even compiles, since the local variable useBackForwardList is uninitialized (but then used!) if [decoder allowsKeyedCoding] returns YES.
John Sullivan
Comment 3 2006-06-10 06:33:41 PDT
Commited in svn revision 14804.
Note You need to log in before you can comment on or make changes to this bug.