Bug 93830

Summary: [V8] Move checkNewLegal() from V8Proxy.h to SafeAllocation.h
Product: WebKit Reporter: Kentaro Hara <haraken>
Component: WebCore JavaScriptAssignee: Kentaro Hara <haraken>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dglazkov, gyuyoung.kim, japhet, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 85330    
Attachments:
Description Flags
Patch
none
Patch none

Kentaro Hara
Reported 2012-08-13 05:37:41 PDT
We can move checkNewLegal() from V8Proxy.h to SafeAllocation.h. In addition, we can rename checkNewLegal() to isValidConstructorMode() for clarification.
Attachments
Patch (5.41 KB, patch)
2012-08-13 05:42 PDT, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
Patch (7.49 KB, patch)
2012-08-13 06:40 PDT, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kentaro Hara
Comment 1 2012-08-13 05:42:17 PDT
Created attachment 157974 [details] Patch
WebKit Review Bot
Comment 2 2012-08-13 06:07:12 PDT
Comment on attachment 157974 [details] Patch Attachment 157974 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13493067
Kentaro Hara
Comment 3 2012-08-13 06:40:39 PDT
Created attachment 157985 [details] Patch
Kentaro Hara
Comment 4 2012-08-13 18:40:00 PDT
Committed r125493: <http://trac.webkit.org/changeset/125493>
Note You need to log in before you can comment on or make changes to this bug.