Bug 93756 – AudioContext::createMediaStreamSource() must create a provider for local MediaStreams

• Component: New Bugs
• Status: RESOLVED FIXED

[Chris Rogers]

AudioContext::createMediaStreamSource() must create a provider for local MediaStreams

[Chris Rogers]

Created attachment 157839 [details]
Patch

[Adam Barth]

Comment on attachment 157839 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=157839&action=review

> Source/WebCore/Modules/mediastream/MediaStream.h:59
> +    virtual bool isLocal() const { return false; }

These sorts of functions tend to point to design problems, but I don't know enough about media stream to be able to give you any useful advice.

> Source/WebCore/Modules/mediastream/MediaStream.h:65
> -
> +    

Why add trailing whitespace?

> Source/WebCore/Modules/webaudio/AudioContext.cpp:400
> -
> +    

ditto

> Source/WebCore/Modules/webaudio/AudioContext.cpp:410
> +        provider = 0;

I'd just initialize the pointer to 0 so as to avoid having uninitialized memory.

> Source/WebCore/Modules/webaudio/AudioContext.cpp:414
> +    node->setFormat(2, sampleRate());

2 -> magic constant?

[Chris Rogers]

Created attachment 157844 [details]
Patch

[Eric Carlson]

Comment on attachment 157844 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=157844&action=review

> Source/WebCore/Modules/webaudio/AudioContext.cpp:414
> +    node->setFormat(2, sampleRate());

Can a media stream only ever have two channels? A comment explaining why and/or a FIXME would be helpful.

[Chris Rogers]

(In reply to comment #4)
> (From update of attachment 157844 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=157844&action=review
> 
> > Source/WebCore/Modules/webaudio/AudioContext.cpp:414
> > +    node->setFormat(2, sampleRate());
> 
> Can a media stream only ever have two channels? A comment explaining why and/or a FIXME would be helpful.

Eric, thanks for the quick review.

I'll add a comment/FIXME explaining this.  Similar to HTMLMediaElement, a MediaStream could have an audio track with 1,2, or more channels.  So ultimately, we'll want this to be more flexible to handle multi-channel audio devices etc.  I'm just in the very early stages of bringing this to life in our implementation, so am making some initial restrictions.

[Chris Rogers]

Committed r125456: <http://trac.webkit.org/changeset/125456>