Bug 93745

Summary: no timeupdate events emitted for media controller
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: MediaAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: eric.carlson, feature-media-reviews, webkit.review.bot
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch eric.carlson: review+

Description Jer Noble 2012-08-10 14:45:48 PDT
no timeupdate events emitted for media controller
Comment 1 Jer Noble 2012-08-10 14:47:10 PDT
<rdar://problem/11753267>
Comment 2 Jer Noble 2012-08-10 14:49:39 PDT
<rdar://problem/11753267>
Comment 3 Jer Noble 2012-08-10 16:04:12 PDT
Created attachment 157828 [details]
Patch
Comment 4 Eric Carlson 2012-08-10 16:11:03 PDT
Comment on attachment 157828 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=157828&action=review

> Source/WebCore/ChangeLog:13
> +        Enforce the spec requirement that the timeupdate event is fired no more often
> +        than every 250ms.

Doesn't it say to fire them *at least* every 250ms?

> Source/WebCore/ChangeLog:17
> +        Add a periodic firing timer to generat timeupdate events during playback.

Nit: "generat" -> "generate"

> Source/WebCore/ChangeLog:25
> +        (MediaController::updatePlaybackState): Start and ntop the timeupdate timer.

Nit: "ntop" -> "stop"
Comment 5 Jer Noble 2012-08-10 16:28:33 PDT
(In reply to comment #4)
> (From update of attachment 157828 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=157828&action=review
> 
> > Source/WebCore/ChangeLog:13
> > +        Enforce the spec requirement that the timeupdate event is fired no more often
> > +        than every 250ms.
> 
> Doesn't it say to fire them *at least* every 250ms?

Well, sort of.  It actually says: 

"Every 15 to 250ms, or whenever the MediaController's media controller position changes, whichever happens least often, the user agent must queue a task to fire a simple event named timeupdate at the MediaController."

So, no more often than "15 to 250ms", but no less often than "15 to 250ms".

> > Source/WebCore/ChangeLog:17
> > +        Add a periodic firing timer to generat timeupdate events during playback.
> 
> Nit: "generat" -> "generate"

Fixed.

> > Source/WebCore/ChangeLog:25
> > +        (MediaController::updatePlaybackState): Start and ntop the timeupdate timer.
> 
> Nit: "ntop" -> "stop"

Fixed.
Comment 6 Jer Noble 2012-08-10 16:50:58 PDT
Committed r125337: <http://trac.webkit.org/changeset/125337>