Summary: | REGRESSION(r125159): ASSERTION FAILED: m_listsInvalidatedAtDocument.contains(list) in Document::unregisterNodeListCache | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Arko Saha <arko> | ||||||
Component: | DOM | Assignee: | Arko Saha <arko> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | naginenis, rniwa | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Arko Saha
2012-08-10 11:31:35 PDT
Created attachment 157803 [details]
Patch
Comment on attachment 157803 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=157803&action=review > LayoutTests/fast/dom/MicroData/propertynodelist-crash.html:4 > +<head> > +</head> No need for the head element. > LayoutTests/fast/dom/MicroData/propertynodelist-crash.html:7 > +<div id='id1' itemprop='foo'></div> Please use more descriptive name like elementWithItemProp. > LayoutTests/fast/dom/MicroData/propertynodelist-crash.html:22 > +if (window.testRunner) { > + setTimeout(function () { testRunner.notifyDone() }, 10); > +} Why do we need this? Do we need to trigger GC? Then try GCController.collect(). Created attachment 157822 [details]
Updated patch
Incorporated review comments.
Comment on attachment 157822 [details] Updated patch View in context: https://bugs.webkit.org/attachment.cgi?id=157822&action=review > LayoutTests/fast/dom/MicroData/propertynodelist-crash.html:10 > +if (window.testRunner) { > + testRunner.dumpAsText(); > +} No curly brackets around a single line statement. > LayoutTests/fast/dom/MicroData/propertynodelist-crash.html:19 > + for (var i = 0; i < 10000; i++) { // force garbage collection > + var s = new String(""); > + } Ditto. Committed r125334: <http://trac.webkit.org/changeset/125334> (In reply to comment #5) > Committed r125334: <http://trac.webkit.org/changeset/125334> Thanks for the fix Arko. |