Bug 93713

Summary:

Web Inspector: render arrays as dir in case they were logged into console prior to the front-end opening.

Product:

WebKit

Reporter:

Pavel Feldman <pfeldman>

Component:

Web Inspector (Deprecated)

Assignee:

Pavel Feldman <pfeldman>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

apavlov, bweinstein, dino, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

93748

Bug Blocks:

Attachments:

Description	Flags
Patch	vsevik: review+

Pavel Feldman

Reported 2012-08-10 05:40:57 PDT

When the user code does console.log() of arrays prior to front-end opening, we dump them in expanded user-friendly manner: [0,0,0] [0,0,1] [0,0,2] However, if this is the same array modified and logged over and over, we confuse user via outputting its last state: [0,0,2] [0,0,2] [0,0,2] In order to avoid the confusion, I'm suggesting that we dump potentially outdated arrays using the "dir" representation, i.e. Array[3]

Attachments
Patch (17.96 KB, patch) 2012-08-10 08:26 PDT, Pavel Feldman	vsevik: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Pavel Feldman

Comment 1 2012-08-10 08:26:14 PDT

Created attachment 157733 [details] Patch

Pavel Feldman

Comment 2 2012-08-10 08:42:43 PDT

Committed r125284: <http://trac.webkit.org/changeset/125284>

Dean Jackson

Comment 3 2012-08-10 15:53:51 PDT

This has caused some test failures/timeouts http://build.webkit.org/builders/Apple%20Lion%20Debug%20WK1%20(Tests) e.g. http://build.webkit.org/results/Apple%20Lion%20Debug%20WK1%20(Tests)/r125329%20(1782)/results.html

Dean Jackson

Comment 4 2012-08-10 16:01:39 PDT

Followup https://bugs.webkit.org/show_bug.cgi?id=93748

Note You need to log in before you can comment on or make changes to this bug.