Bug 93672

Summary:

LayoutTest: Debugger tests are failing on Windows, gardening

Product:

WebKit

Reporter:

Roger Fong <roger_fong>

Component:

Web Inspector (Deprecated)

Assignee:

Roger Fong <roger_fong>

Status:

RESOLVED INVALID

Severity:

Normal

CC:

thorton, webkit.review.bot

Priority:

Keywords:

LayoutTestFailure

Version:

528+ (Nightly build)

Hardware:

OS:

Windows 7

Attachments:

Description	Flags
patch	eric: review+, webkit.review.bot: commit-queue-
Same patch, updated to current revision...	thorton: review-, thorton: commit-queue-

Roger Fong

Reported 2012-08-09 18:04:29 PDT

Adding following test to Windows skip list: inspector/debugger/debugger-activation-crash2.html inspector/debugger/debugger-set-breakpoint-regex.html inspector/debugger/pause-in-internal-script.html inspector/debugger/script-formatter-breakpoints.html inspector/debugger/set-breakpoint.html inspector/debugger/watch-expressions-panel-switch.html

Attachments
patch (1.75 KB, patch) 2012-08-09 18:09 PDT, Roger Fong	eric: review+ webkit.review.bot: commit-queue-	Details Formatted Diff Diff
Same patch, updated to current revision... (1.67 KB, patch) 2012-08-13 11:14 PDT, Roger Fong	thorton: review- thorton: commit-queue-	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Roger Fong

Comment 1 2012-08-09 18:09:07 PDT

Created attachment 157602 [details] patch

Eric Seidel (no email)

Comment 2 2012-08-11 02:43:40 PDT

Comment on attachment 157602 [details] patch rs=me.

WebKit Review Bot

Comment 3 2012-08-11 02:44:49 PDT

Comment on attachment 157602 [details] patch Rejecting attachment 157602 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: r', u'Eric Seidel']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Parsed 2 diffs from patch file(s). patching file LayoutTests/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file LayoutTests/platform/win/Skipped Hunk #1 FAILED at 1969. 1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/platform/win/Skipped.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Eric Seidel']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/13483183

Roger Fong

Comment 4 2012-08-13 11:14:54 PDT

Created attachment 158051 [details] Same patch, updated to current revision...

Tim Horton

Comment 5 2012-08-13 11:23:45 PDT

Is there already a bug tracking these failures? If not, make sure to keep this one open.

Tim Horton

Comment 6 2012-08-13 11:51:13 PDT

Apparently the tests were fixed over the weekend. No idea if we can stop the Cq, but we'll try (and roll out the skip if not).

Roger Fong

Comment 7 2012-08-13 12:31:36 PDT

Was fixed here: http://trac.webkit.org/changeset/125394

Note You need to log in before you can comment on or make changes to this bug.