Summary: | [V8] V8Utilities::throwTypeMismatchException() should use setDOMException() | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Kentaro Hara <haraken> | ||||||
Component: | WebCore JavaScript | Assignee: | Kentaro Hara <haraken> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | abarth, dglazkov, japhet, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 85330 | ||||||||
Attachments: |
|
Description
Kentaro Hara
2012-08-09 05:23:16 PDT
Created attachment 157446 [details]
Patch
Comment on attachment 157446 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=157446&action=review > Source/WebCore/bindings/v8/V8Utilities.cpp:197 > -void throwTypeMismatchException(v8::Isolate* isolate) > +void setTypeMismatchException(v8::Isolate* isolate) > { > - V8Proxy::throwError(V8Proxy::GeneralError, "TYPE_MISMATCH_ERR: DOM Exception 17", isolate); > + V8Proxy::setDOMException(TYPE_MISMATCH_ERR, isolate); > } Presumably we should just inline this function into it's one caller. Comment on attachment 157446 [details] Patch Attachment 157446 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13460593 (In reply to comment #2) > > +void setTypeMismatchException(v8::Isolate* isolate) > > { > > - V8Proxy::throwError(V8Proxy::GeneralError, "TYPE_MISMATCH_ERR: DOM Exception 17", isolate); > > + V8Proxy::setDOMException(TYPE_MISMATCH_ERR, isolate); > > } > > Presumably we should just inline this function into it's one caller. I tried it but it's not easy to resolve circular dependency. V8Proxy.h includes V8Utilities.h. So V8Utilities.h cannot call V8Proxy::xxx(). Created attachment 157579 [details]
patch for landing
Comment on attachment 157579 [details] patch for landing Clearing flags on attachment: 157579 Committed r125236: <http://trac.webkit.org/changeset/125236> |