Bug 93600

Summary: [GTK] Default signal handler for WebKitWebView::should-show-delete-interface-for-element overrides default result
Product: WebKit Reporter: Martin Robinson <mrobinson>
Component: WebKitGTKAssignee: Martin Robinson <mrobinson>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Martin Robinson 2012-08-09 02:03:48 PDT 
Since the default signal handler for WebKitWebView::should-show-delete-interface-for-element overrides the default value, which means that the delete interface still appears.
Comment 1 Martin Robinson 2012-08-09 05:06:20 PDT 
Created attachment 157436 [details]
Patch
Comment 2 Xan Lopez 2012-08-09 05:22:51 PDT 
Comment on attachment 157436 [details]
Patch

Hrm, should we change the thing in the class struct to be a dummy pointer?
Comment 3 Martin Robinson 2012-08-09 05:25:40 PDT 
Do you mean should_allow_editing_action? If so, it's used by other editing signals, so we have to keep it around.
Comment 4 Xan Lopez 2012-08-09 05:27:52 PDT 
Comment on attachment 157436 [details]
Patch

I see!

r=me
Comment 5 WebKit Review Bot 2012-08-09 11:08:31 PDT 
Comment on attachment 157436 [details]
Patch

Rejecting attachment 157436 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

ERROR: /mnt/git/webkit-commit-queue/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://queues.webkit.org/results/13473043
Comment 6 WebKit Review Bot 2012-08-13 03:36:03 PDT 
Comment on attachment 157436 [details]
Patch

Clearing flags on attachment: 157436

Committed r125407: <http://trac.webkit.org/changeset/125407>
Comment 7 WebKit Review Bot 2012-08-13 03:36:07 PDT 
All reviewed patches have been landed.  Closing bug.