Bug 93586
| Summary: | Layout Test fast/forms/autocomplete-off-with-default-value-does-not-clear.html is failing | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Takashi Toyoshima <toyoshim> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | beidson, tkent, yutak |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Takashi Toyoshima
The following layout test is timedout on all chromium ports
fast/forms/autocomplete-off-with-default-value-does-not-clear.html
This test is added by https://bugs.webkit.org/show_bug.cgi?id=93544
And patch and test looks no problem.
Is there missing DRT feature to run this test?
I tried this test with long timeout argument in local machine, but it didn't finish.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Takashi Toyoshima
Update extension for now.
http://trac.webkit.org/changeset/125158
Brady,
Do you have any hint on this timeout?
Kent,
If you know the right person to handle this issue, please ping the person.
Thanks,
Brady Eidson
(In reply to comment #1)
> Update extension for now.
> http://trac.webkit.org/changeset/125158
>
> Brady,
> Do you have any hint on this timeout?
Yup, simple - The test will only work with the page cache enabled and functioning, and I think that can't happen with chromium.
This was an oversight on my part, I apologize. We should skip it for all ports that don't fit in to that description.
Brady Eidson
There was already a section of the chromium TestExpectations dedicated to "doesn't support page cache", so I added it there in http://trac.webkit.org/changeset/125182
Yuta Kitamura
There were two duplicate lines in TestExpectations (one with SKIP, the other without). I removed the latter to fix a lint error:
<http://trac.webkit.org/changeset/125241>
Brady Eidson
(In reply to comment #4)
> There were two duplicate lines in TestExpectations (one with SKIP, the other without). I removed the latter to fix a lint error:
>
> <http://trac.webkit.org/changeset/125241>
Ah, didn't know that's what "update extension for now." meant. Sorry about that...
Better that it's in the "doesn't support page cache" block for now, anyways!
Takashi Toyoshima
Brady, and Yuta,
Thank you for handling this.
> Ah, didn't know that's what "update extension for now." meant. Sorry about that...
Oops... sorry, I made you confused.
Yes, it was typo. I meant update TestExpectations.