Bug 93559

Summary:

Web Inspector: CodeGeneratorInspector.py: add complete support for TypeBuilder::Array

Product:

WebKit

Reporter:

Peter Rybin <prybin>

Component:

Web Inspector (Deprecated)

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none
Patch	none

Peter Rybin

Reported 2012-08-08 17:16:08 PDT

Currently TypeBuilder::Array supports not all possible item types, for example Array<InspectorObject> misses assertCorrectValue method.

Attachments
Patch (11.98 KB, patch) 2012-08-08 17:38 PDT, Peter Rybin	no flags	Details Formatted Diff Diff
Patch (11.81 KB, patch) 2012-08-09 09:58 PDT, Peter Rybin	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Peter Rybin

Comment 1 2012-08-08 17:38:52 PDT

Created attachment 157347 [details] Patch

Pavel Feldman

Comment 2 2012-08-08 23:10:12 PDT

Comment on attachment 157347 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=157347&action=review > Source/WebCore/ChangeLog:8 > + Additional information of the change such as approach, rationale. Please add per-function descriptions below (OOPS!). Please remove this line.

WebKit Review Bot

Comment 3 2012-08-09 00:05:14 PDT

Comment on attachment 157347 [details] Patch Rejecting attachment 157347 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: t/InspectorTypeBuilder.h:267: error: 'assertArray' is not a member of 'WebCore::TypeBuilder::RuntimeCastHelper' make: *** [out/Debug/obj.target/webcore_dom/Source/WebCore/dom/CDATASection.o] Error 1 make: *** Waiting for unfinished jobs.... make: *** [out/Debug/obj.target/webcore_dom/Source/WebCore/dom/ContextFeatures.o] Error 1 make: *** [out/Debug/obj.target/webcore_dom/Source/WebCore/dom/Attr.o] Error 1 make: *** [out/Debug/obj.target/webcore_dom/Source/WebCore/dom/ActiveDOMObject.o] Error 1 Full output: http://queues.webkit.org/results/13456792

Peter Rybin

Comment 4 2012-08-09 09:58:48 PDT

Created attachment 157475 [details] Patch

WebKit Review Bot

Comment 5 2012-08-09 21:51:21 PDT

Comment on attachment 157475 [details] Patch Clearing flags on attachment: 157475 Committed r125248: <http://trac.webkit.org/changeset/125248>

WebKit Review Bot

Comment 6 2012-08-09 21:51:26 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.