Bug 93552
| Summary: | [Mac] [WK2] inspector/device-orientation-success.html, added by r124484, is failing | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Dean Jackson <dino> |
| Component: | Web Inspector (Deprecated) | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED INVALID | ||
| Severity: | Normal | CC: | apavlov, bweinstein, dino, joepeck, keishi, kpiascik, loislo, pfeldman, pmuellr, rik, rniwa, yurys |
| Priority: | P2 | Keywords: | LayoutTestFailure |
| Version: | 528+ (Nightly build) | ||
| Hardware: | All | ||
| OS: | All | ||
| Bug Depends on: | 91008 | ||
| Bug Blocks: | |||
Dean Jackson
http://trac.webkit.org/changeset/124484 added inspector/device-orientation-success.html which is failing on Mac ports. e.g.
http://build.webkit.org/results/Apple%20Lion%20Release%20WK1%20(Tests)/r125103%20(2133)/results.html
--- /Volumes/Data/slave/lion-release-tests-wk1/build/layout-test-results/inspector/device-orientation-success-expected.txt
+++ /Volumes/Data/slave/lion-release-tests-wk1/build/layout-test-results/inspector/device-orientation-success-actual.txt
@@ -1,3 +1,1 @@
-CONSOLE MESSAGE: line 17: alpha: 20 beta: 30 gamma: 40
-CONSOLE MESSAGE: line 17: alpha: 1.1 beta: 2.2 gamma: 3.3
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Dean Jackson
Test expectations updated: http://trac.webkit.org/changeset/125119
Pavel Feldman
@kpiascik: do you want to look into it?
Konrad Piascik
Are inspector layout tests on mac-lion supported? I see a bunch of timed out tests for inspector with this results set. Also I want to double check whether this is for safari or chromium?
Pavel Feldman
(In reply to comment #3)
> Are inspector layout tests on mac-lion supported?
Yes
> I see a bunch of timed out tests for inspector with this results set. Also I want to double check whether this is for safari or chromium?
It is Safari
Konrad Piascik
navigating to http://www.html5rocks.com/en/tutorials/device/orientation/deviceorientationsample.html in safari says that device orientation is not supported. Since this is not supported the test should be skipped on mac. Apologies for not doing this in the original patch.
Unless there are objections we can close this as invalid and update the TestExpectations file with a proper comment.
Ryosuke Niwa
This test is now only failing on WK2. Updated the test expectations accordingly in http://trac.webkit.org/changeset/138734.
Brian Burg
Closing as invalid, as this bug pertains to the old inspector UI and/or its tests.
Please file a new bug (https://www.webkit.org/new-inspector-bug) if the bug/feature/issue is still relevant to WebKit trunk.