Bug 93548

Summary: [BlackBerry] Fix "-fPIC" define in the BlackBerry build
Product: WebKit Reporter: Ming Xie <mxie>
Component: WebKit BlackBerryAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: gyuyoung.kim, rakuco, rwlbuis, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Other   
Attachments:
Description Flags
Patch none

Ming Xie
Reported 2012-08-08 16:28:23 PDT
In the current CMake release (version 2.8.5), ${CMAKE_SHARED_LIBRARY_C_FLAGS} and ${CMAKE_SHARED_LIBRARY_CXX_FLAGS} is set to empty (See cmake/Modules/Platform/QNX.cmake) This breaks the assumption which WebKit CMake build system makes in Source/cmake/WebKitHelper.cmake
Attachments
Patch (1.77 KB, patch)
2012-08-08 16:38 PDT, Ming Xie 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ming Xie
Comment 1 2012-08-08 16:38:46 PDT
Created attachment 157331 [details] Patch
Rob Buis
Comment 2 2012-08-08 16:39:25 PDT
Comment on attachment 157331 [details] Patch LGTM.
WebKit Review Bot
Comment 3 2012-08-08 17:18:16 PDT
Comment on attachment 157331 [details] Patch Clearing flags on attachment: 157331 Committed r125121: <http://trac.webkit.org/changeset/125121>
WebKit Review Bot
Comment 4 2012-08-08 17:18:21 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.