Summary: | ASSERT(m_workerContext->isSharedWorkerContext()) in WorkerScriptController::initScript() when providing Content Security Policy to dedicated worker. | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Thomas Sepez <tsepez> | ||||||||
Component: | WebKit Misc. | Assignee: | Thomas Sepez <tsepez> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | abarth, webkit.review.bot | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Thomas Sepez
2012-08-08 14:18:10 PDT
Created attachment 157294 [details]
Test case
Added testcase, derived from work on https://bugs.webkit.org/show_bug.cgi?id=93392 hence the naming though for the purposes of this bug, the settimeout part doesn't get reached and is of no concern. Created attachment 157323 [details]
Proposed patch.
Comment on attachment 157323 [details]
Proposed patch.
Can we add an ASSERT to the base class to make sure applyContentSecurityPolicyFromString is called?
Created attachment 157336 [details]
Patch, add assert.
Sure. We'll postpone the creation of the CSP object until the new method is called, then we'll assert that there's a CSP.
Comment on attachment 157336 [details]
Patch, add assert.
Rockin'
Comment on attachment 157336 [details] Patch, add assert. Clearing flags on attachment: 157336 Committed r125120: <http://trac.webkit.org/changeset/125120> All reviewed patches have been landed. Closing bug. |