Bug 9352

Summary:

Webkit doesn't respect stroke-width in SVG for smaller <circle>s

Product:

WebKit

Reporter:

Ted Pearson <ted>

Component:

SVG

Assignee:

Nobody <webkit-unassigned>

Status:

VERIFIED FIXED

Severity:

Normal

Priority:

Version:

420+

Hardware:

Mac

OS:

OS X 10.4

URL:

http://tedpearson.com/uploads/webkitstroke.php

Attachments:

Description	Flags
First attempt	mjs: review-
Now with testcase	darin: review+

Ted Pearson

Reported 2006-06-07 21:02:31 PDT

See the URL provided with this bug, and please compare how it is rendered in Firefox 1.5.0.4 with the way it is rendered in the latest webkit nightly build. Both the large and small circle are set to a stroke-width of 10 pixels. However, in Safari, it as rendered as more like 3 pixels. If you increase the radius of the smaller circle, Safari will gradually increase the width of the border. Safari should render this the way Firefox is rendering it, as it is correct.

Attachments
First attempt (3.60 KB, patch) 2006-06-09 12:49 PDT, Rob Buis	mjs: review-	Details Formatted Diff Diff
Now with testcase (35.49 KB, patch) 2006-06-19 13:18 PDT, Rob Buis	darin: review+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Mark Rowe (bdash)

Comment 1 2006-06-08 00:21:36 PDT

Confirmed with latest nightly.

Ted Pearson

Comment 2 2006-06-08 15:42:22 PDT

Here's a link to what you should be seeing, FYI: http://tedpearson.com/uploads/shouldsee.png

Rob Buis

Comment 3 2006-06-09 12:49:18 PDT

Created attachment 8788 [details] First attempt The change works for the testcase and no regressions on run-webkit-tests. Let me know if the change can be done cleaner. Cheers, Rob.

Maciej Stachowiak

Comment 4 2006-06-18 20:55:03 PDT

Looks like a good fix, just needs a test case.

Maciej Stachowiak

Comment 5 2006-06-18 20:55:36 PDT

Comment on attachment 8788 [details] First attempt r- for lack of test case, but IMO this would be landable with the publicly posted example as a layout test.

Rob Buis

Comment 6 2006-06-19 13:18:06 PDT

Created attachment 8924 [details] Now with testcase Since I think the normal layouttest shows no difference, I also introduce the pixel test. Cheers, Rob.

Darin Adler

Comment 7 2006-06-19 13:25:35 PDT

Comment on attachment 8924 [details] Now with testcase r=mjs

David Kilzer (:ddkilzer)

Comment 8 2006-06-24 14:50:37 PDT

Committed revision 15021.

Ted Pearson

Comment 9 2006-07-06 08:31:45 PDT

Fix works in latest nightlies, including my actual svg/ajax game where i noticed it before making the testcase redux. Thanks!

Note You need to log in before you can comment on or make changes to this bug.