Summary: | Oscillator node should throw exception if type is assigned an invalid value | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Raymond Toy <rtoy> | ||||||
Component: | Web Audio | Assignee: | Raymond Toy <rtoy> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | abarth, crogers, eric.carlson, feature-media-reviews, ojan, s.choi, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | 93194 | ||||||||
Bug Blocks: | |||||||||
Attachments: |
|
Description
Raymond Toy
2012-08-08 09:23:42 PDT
Add dependency on 93194 so that we get tests infrastructure to add tests for this. Created attachment 157470 [details]
Patch
Comment on attachment 157470 [details] Patch Rejecting attachment 157470 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: CT (content): Merge conflict in LayoutTests/ChangeLog Failed to merge in the changes. Patch failed at 0001 (r125185) http/tests/images/jpg-img-partial-load.html timeout on Lion When you have resolved this problem run "git rebase --continue". If you would prefer to skip this patch, instead run "git rebase --skip". To restore the original branch and stop rebasing run "git rebase --abort". rebase refs/remotes/origin/master: command returned error: 1 Died at Tools/Scripts/update-webkit line 164. Full output: http://queues.webkit.org/results/13459674 Comment on attachment 157470 [details]
Patch
I just checked and my current tree has the most recent webkit roll. Can we try committing again?
Created attachment 158045 [details]
Patch
(In reply to comment #5) > Created an attachment (id=158045) [details] > Patch Patch regenerated from latest sources. Comment on attachment 158045 [details] Patch Clearing flags on attachment: 158045 Committed r125460: <http://trac.webkit.org/changeset/125460> All reviewed patches have been landed. Closing bug. |