Bug 93474

Summary: [GStreamer] 0.11 build broken (again)
Product: WebKit Reporter: Philippe Normand <pnormand>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: David.Ronis, gustavo, menard, mrobinson, philn, tmpsantos, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
webkit-ews: commit-queue-
Patch mrobinson: review+, mrobinson: commit-queue-

Description Philippe Normand 2012-08-08 06:56:44 PDT 
Patch incoming
Comment 1 Philippe Normand 2012-08-08 07:07:45 PDT 
Created attachment 157210 [details]
Patch
Comment 2 Philippe Normand 2012-08-08 07:16:42 PDT 
Comment on attachment 157210 [details]
Patch

Err, wrong patch.
Comment 3 Early Warning System Bot 2012-08-08 08:15:23 PDT 
Comment on attachment 157210 [details]
Patch

Attachment 157210 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/13450918
Comment 4 Gyuyoung Kim 2012-08-08 08:21:44 PDT 
Comment on attachment 157210 [details]
Patch

Attachment 157210 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/13463011
Comment 5 Early Warning System Bot 2012-08-08 08:27:55 PDT 
Comment on attachment 157210 [details]
Patch

Attachment 157210 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/13452656
Comment 6 Philippe Normand 2012-08-08 09:11:13 PDT 
Created attachment 157233 [details]
Patch
Comment 7 Martin Robinson 2012-08-08 09:21:28 PDT 
Comment on attachment 157233 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=157233&action=review

> configure.ac:473
> +# fastream-0.1 depends on gstreamer 0.10 currently. Disable

Small typo here: fastream -> farstream
Comment 8 Philippe Normand 2012-08-08 09:53:09 PDT 
Committed r125041: <http://trac.webkit.org/changeset/125041>
Comment 9 Thiago Marcos P. Santos 2012-08-08 10:03:08 PDT 
This patch broke EFL build.

Building CXX object Source/WebCore/CMakeFiles/webcore_efl.dir/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp.o
/home/buildslave-1/webkit-buildslave/efl-linux-64-debug/build/Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp: In member function ‘virtual void StreamingClient::didReceiveResponse(WebCore::ResourceHandle*, const WebCore::ResourceResponse&)’:
/home/buildslave-1/webkit-buildslave/efl-linux-64-debug/build/Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:856:159: error: cannot convert ‘GstTagList* {aka _GstStructure*}’ to ‘GstPad* {aka _GstPad*}’ for argument ‘2’ to ‘void notifyGstTagsOnPad(GstElement*, GstPad*, GstTagList*)’
make[2]: *** [Source/WebCore/CMakeFiles/webcore_efl.dir/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp.o] Error 1
make[2]: *** Waiting for unfinished jobs....
Comment 10 Philippe Normand 2012-08-08 10:08:15 PDT 
Oops, thanks Thiago. Build fix in r125043!
Comment 11 Philippe Normand 2012-09-13 08:44:51 PDT 
*** Bug 94955 has been marked as a duplicate of this bug. ***