|Summary:||Extract the definition of NativeImagePtr from ImageSource.h into NativeImagePtr.h.|
|Product:||WebKit||Reporter:||Dongseong Hwang <dongseong.hwang>|
|Component:||Images||Assignee:||Kwang Yul Seo <skyul>|
|Severity:||Normal||CC:||abarth, gns, hclam, simon.fraser, skyul, webkit.review.bot, xan.lopez|
|Version:||528+ (Nightly build)|
|Bug Depends on:||93573|
|Bug Blocks:||90375, 93467|
Description Dongseong Hwang 2012-08-08 05:08:34 PDT
Image.h includes ImageSource.h in order to know the definition of NativeImagePtr. But Image does not need to know the definition of ImageSource. So, this patch extracts the definition of NativeImagePtr from ImageSource.h into NativeImagePtr.h. This is a preparation for asynchronous image decoding. Async decoding will need a callback function, which sends a NativeImagePtr to clients, and the callback must know the definition of NativeImagePtr, not ImageSource.
Comment 2 Gustavo Noronha (kov) 2012-08-08 06:54:34 PDT
Comment on attachment 157186 [details] Patch Attachment 157186 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/13455502
Comment 3 Hin-Chung Lam 2012-08-08 08:51:35 PDT
+1 I like this is separated.
Comment 4 Adam Barth 2012-08-08 10:04:41 PDT
Comment on attachment 157186 [details] Patch Ok. Looks like you've got a build issue on GTK to resolve before landing.
Comment 5 Kwang Yul Seo 2012-08-08 14:40:18 PDT
(In reply to comment #4) > (From update of attachment 157186 [details]) > Ok. Looks like you've got a build issue on GTK to resolve before landing. Thanks. I will land the patch after fixing the build issue.
Comment 6 Kwang Yul Seo 2012-08-08 17:39:52 PDT
Comment on attachment 157186 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=157186&action=review > Source/WebCore/platform/graphics/NativeImagePtr.h:2 > + * Copyright (C) 2012 Company 100 Inc. All rights reserved. I think we should keep the original copyright of ImageSource.h because this patch simply copies the definition of NativeImagePtr from ImageSource.h. Copyright (C) 2004, 2005, 2006 Apple Computer, Inc. All rights reserved. Copyright (C) 2007-2008 Torch Mobile, Inc.
Comment 7 Dongseong Hwang 2012-08-08 18:42:45 PDT
Thank all for review.
Comment 8 Kwang Yul Seo 2012-08-08 18:44:22 PDT
Created attachment 157363 [details] Patch for landing
Comment 9 WebKit Review Bot 2012-08-08 19:31:59 PDT
Comment on attachment 157363 [details] Patch for landing Rejecting attachment 157363 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 ERROR: /mnt/git/webkit-commit-queue/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/13451995
Comment 10 Kwang Yul Seo 2012-08-08 19:36:02 PDT
Committed r125143: <http://trac.webkit.org/changeset/125143>
Comment 11 WebKit Review Bot 2012-08-08 20:17:56 PDT
Re-opened since this is blocked by 93573
Comment 12 Kwang Yul Seo 2012-08-09 05:54:13 PDT
Created attachment 157458 [details] Patch for landing
Comment 13 WebKit Review Bot 2012-08-09 13:10:24 PDT
Comment on attachment 157458 [details] Patch for landing Rejecting attachment 157458 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: (content): Merge conflict in Source/WebCore/ChangeLog Failed to merge in the changes. Patch failed at 0001 [chromium] Pass mask scale and offset to shaders for correct masking When you have resolved this problem run "git rebase --continue". If you would prefer to skip this patch, instead run "git rebase --skip". To restore the original branch and stop rebasing run "git rebase --abort". rebase refs/remotes/origin/master: command returned error: 1 Died at Tools/Scripts/update-webkit line 164. Full output: http://queues.webkit.org/results/13457935
Comment 14 WebKit Review Bot 2012-08-09 14:25:47 PDT
Comment on attachment 157458 [details] Patch for landing Clearing flags on attachment: 157458 Committed r125203: <http://trac.webkit.org/changeset/125203>
Comment 15 WebKit Review Bot 2012-08-09 14:25:53 PDT
All reviewed patches have been landed. Closing bug.