Summary: | [Microdata] HTMLPropertiesCollection does not contain all properties when item is not attached to the DOM tree | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Arko Saha <arko> | ||||
Component: | DOM | Assignee: | Arko Saha <arko> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | rniwa, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 92986 | ||||||
Attachments: |
|
Description
Arko Saha
2012-08-08 02:23:54 PDT
Created attachment 157165 [details]
Patch
Comment on attachment 157165 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=157165&action=review > Source/WebCore/dom/DynamicNodeList.cpp:45 > + Node* root = m_ownerNode.get(); > + while (Node* parent = root->parentNode()) > + root = parent; Should we do this for labels node list and radio node list also? (In reply to comment #2) > (From update of attachment 157165 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=157165&action=review > > > Source/WebCore/dom/DynamicNodeList.cpp:45 > > + Node* root = m_ownerNode.get(); > > + while (Node* parent = root->parentNode()) > > + root = parent; > > Should we do this for labels node list and radio node list also? Sure. Is is ok to file a new bug to resolve it as we need to add test cases for the same? (In reply to comment #3) > (In reply to comment #2) > > (From update of attachment 157165 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=157165&action=review > > > > > Source/WebCore/dom/DynamicNodeList.cpp:45 > > > + Node* root = m_ownerNode.get(); > > > + while (Node* parent = root->parentNode()) > > > + root = parent; > > > > Should we do this for labels node list and radio node list also? > > Sure. Is is ok to file a new bug to resolve it as we need to add test cases for the same? Yes. In fact, that's probably preferable. (In reply to comment #4) > (In reply to comment #3) > > (In reply to comment #2) > > > (From update of attachment 157165 [details] [details] [details]) > > > View in context: https://bugs.webkit.org/attachment.cgi?id=157165&action=review > > > > > > > Source/WebCore/dom/DynamicNodeList.cpp:45 > > > > + Node* root = m_ownerNode.get(); > > > > + while (Node* parent = root->parentNode()) > > > > + root = parent; > > > > > > Should we do this for labels node list and radio node list also? > > > > Sure. Is is ok to file a new bug to resolve it as we need to add test cases for the same? > > Yes. In fact, that's probably preferable. Ok. Thanks for the clarification. Comment on attachment 157165 [details] Patch Clearing flags on attachment: 157165 Committed r125157: <http://trac.webkit.org/changeset/125157> All reviewed patches have been landed. Closing bug. |