Bug 93397

Summary: [Qt] 32-bit PowerPC Mac needs NS_BUILD_32_LIKE_64, too
Product: WebKit Reporter: Samuel Bronson <naesten>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED INVALID    
Severity: Normal CC: webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac (PowerPC)   
OS: OS X 10.5   
Attachments:
Description Flags
Trivial fix.
none
Slightly less trivial patch. none

Samuel Bronson
Reported 2012-08-07 14:40:59 PDT
This is a repeat of id=69914, except on 32-bit PowerPC. Trivial patch attached.
Attachments
Trivial fix. (454 bytes, patch)
2012-08-07 14:45 PDT, Samuel Bronson 		no flags
DetailsFormatted DiffDiff
Slightly less trivial patch. (31 bytes, text/plain)
2012-08-08 10:02 PDT, Samuel Bronson 		no flags
Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Samuel Bronson
Comment 1 2012-08-07 14:45:10 PDT
Created attachment 157012 [details] Trivial fix.
WebKit Review Bot
Comment 2 2012-08-07 14:51:49 PDT
Attachment 157012 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files']" exit_code: 1 Total errors found: 0 in 0 files If any of these errors are false positives, please file a bug against check-webkit-style.
Samuel Bronson
Comment 3 2012-08-07 14:53:35 PDT
So *that's* what that button does...
Samuel Bronson
Comment 4 2012-08-08 10:02:46 PDT
Created attachment 157240 [details] Slightly less trivial patch. Whoops. Missed a spot before, so this time I actually grepped. (Which, of course, only turned up the two places I had already patched when I ran the grep.)
Jocelyn Turcotte
Comment 5 2014-02-03 03:22:04 PST
=== Bulk closing of Qt bugs === If you believe that this bug report is still relevant for a non-Qt port of webkit.org, please re-open it and remove [Qt] from the summary. If you believe that this is still an important QtWebKit bug, please fill a new report at https://bugreports.qt-project.org and add a link to this issue. See http://qt-project.org/wiki/ReportingBugsInQt for additional guidelines.
Note You need to log in before you can comment on or make changes to this bug.