Summary: | [WebGL] Add support for EXT_robustness | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Joshua Netterfield <jnetterfield> | ||||||||
Component: | WebGL | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | ap, cc-bugs, cmarrin, ddkilzer, dev+webkit, dglazkov, dino, eoconnor, eric, gyuyoung.kim, jamesr, kbr, mifenton, mjs, noam, rakuco, roger_fong, simon.fraser, staikos, thorton, webkit.review.bot | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Joshua Netterfield
2012-08-07 11:23:52 PDT
Created attachment 157027 [details]
Patch
Comment on attachment 157027 [details] Patch Attachment 157027 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13458012 Created attachment 157498 [details]
Patch
Created attachment 157501 [details]
Patch
Adjusted ChangeLog. I presume we don't have new tests for this because you are unable to actually trip it so far? Correct - with the improvements in the QC driver & the introduction of ANGLE, I have not been able to cause a hardware reset (there is a passing test which causes a reset). I'll add this to the ChangeLog. (In reply to comment #7) > Correct - with the improvements in the QC driver & the introduction of ANGLE, I have not been able to cause a hardware reset (there is a passing test which causes a reset). I'll add this to the ChangeLog. No need, I'll r+ it I'm not sure this is the right place to do the robustness validation. Instead, can we require that implementations of GraphicsContext3D are robust? There may be many ways to accomplish this that are specific to the backend. Comment on attachment 157501 [details]
Patch
I want to hold off on this until some of the more experienced WebGL bindings folks can take a look - they're currently at SIGGRAPH.
(In reply to comment #9) > I'm not sure this is the right place to do the robustness validation. Instead, can we require that implementations of GraphicsContext3D are robust? There may be many ways to accomplish this that are specific to the backend. We had concerns with how to recover in basically all cases. Open to suggestions. This was the best we came up with as a first step. There is definitely more work to do here. Comment on attachment 157501 [details]
Patch
This looks okay to me. While it might seem a little gross to check in shared code whether the robustness extension is present, doing so will enable more code sharing between platforms. I'll try setting the cq+ bit.
Comment on attachment 157501 [details] Patch Clearing flags on attachment: 157501 Committed r125349: <http://trac.webkit.org/changeset/125349> All reviewed patches have been landed. Closing bug. |