Bug 93339 – [Qt][Win] Build system bug revealed by r124835

• Component: New Bugs
• Status: RESOLVED FIXED

[Csaba Osztrogonác]

r124835 broke the Qt 5 - Windows - MSVC build:

	link /LIBPATH:"c:\WebKitBuildSlave\qt5\qtbase\lib" /NOLOGO /DYNAMICBASE /NXCOMPAT /INCREMENTAL:NO /DLL /MANIFEST /MANIFESTFILE:"obj/release\QtWebKit.intermediate.manifest" /VERSION:5.00 /OUT:..\lib\QtWebKit5.dll @C:\Users\WEBKIT~1\AppData\Local\Temp\2\nm5FE9.tmp 
   Creating library ..\lib\QtWebKit5.lib and object ..\lib\QtWebKit5.exp
WebCore.lib(JSDocumentCustom.obj) : error LNK2019: unresolved external symbol "class WebCore::DOMWindow * __cdecl WebCore::activeDOMWindow(class JSC::ExecState *)" (?activeDOMWindow@WebCore@@YAPAVDOMWindow@1@PAVExecState@JSC@@@Z) referenced in function "public: void __thiscall WebCore::JSDocument::setLocation(class JSC::ExecState *,class JSC::JSValue)" (?setLocation@JSDocument@WebCore@@QAEXPAVExecState@JSC@@VJSValue@4@@Z)
WebCore.lib(JSDOMWindowCustom.obj) : error LNK2001: unresolved external symbol "class WebCore::DOMWindow * __cdecl WebCore::activeDOMWindow(class JSC::ExecState *)" (?activeDOMWindow@WebCore@@YAPAVDOMWindow@1@PAVExecState@JSC@@@Z)
WebCore.lib(JSLocationCustom.obj) : error LNK2001: unresolved external symbol "class WebCore::DOMWindow * __cdecl WebCore::activeDOMWindow(class JSC::ExecState *)" (?activeDOMWindow@WebCore@@YAPAVDOMWindow@1@PAVExecState@JSC@@@Z)
WebCore.lib(JSDocumentCustom.obj) : error LNK2019: unresolved external symbol "class WebCore::DOMWindow * __cdecl WebCore::firstDOMWindow(class JSC::ExecState *)" (?firstDOMWindow@WebCore@@YAPAVDOMWindow@1@PAVExecState@JSC@@@Z) referenced in function "public: void __thiscall WebCore::JSDocument::setLocation(class JSC::ExecState *,class JSC::JSValue)" (?setLocation@JSDocument@WebCore@@QAEXPAVExecState@JSC@@VJSValue@4@@Z)
WebCore.lib(JSDOMWindowCustom.obj) : error LNK2001: unresolved external symbol "class WebCore::DOMWindow * __cdecl WebCore::firstDOMWindow(class JSC::ExecState *)" (?firstDOMWindow@WebCore@@YAPAVDOMWindow@1@PAVExecState@JSC@@@Z)
WebCore.lib(JSLocationCustom.obj) : error LNK2001: unresolved external symbol "class WebCore::DOMWindow * __cdecl WebCore::firstDOMWindow(class JSC::ExecState *)" (?firstDOMWindow@WebCore@@YAPAVDOMWindow@1@PAVExecState@JSC@@@Z)
..\lib\QtWebKit5.dll : fatal error LNK1120: 2 unresolved externals

[Adam Barth]

Hi

[Adam Barth]

I talked with Ossy a bit in #webkit about this failure, but I'm not sure where to start to fix it.  I don't even know which build system is used by this port.

It just looks like BindingState.cpp is missing from the build.  The apple-win port gets this file via JSBindingAllInOne.cpp.

[Simon Hausmann]

Yeah, this looks like a dependency problem in the build system perhaps. I don't see anything Windows specific in http://trac.webkit.org/changeset/124835 . It would be interesting to see the entire build log of the bot. My bet is a that a clean build fixes it :/

[Csaba Osztrogonác]

Clean build solved this problem, so it is a build system bug.

[Simon Hausmann]

Do you have the original build log somewhere? Would love to see what happened.

After all it should be just qmake and nmake.

[Simon Hausmann]

Found it at http://build.webkit.sed.hu/builders/Qt%20Windows%2032-bit%20Release%20Qt5/builds/1277/steps/compile-webkit/logs/stdio

[Tor Arne Vestbø]

The SVN revision check in build-webkit fails:

'LC_ALL' is not recognized as an internal or external command,
operable program or batch file.
Unable to determine current SVN revision in C:/WebKitBuildSlave/szeged-windows-1/qt-windows-32-release/build at C:/WebKitBuildSlave/szeged-windows-1/qt-windows-32-release/build/Tools/Scripts/VCSUtils.pm line 384.

This causes us to not do "make incremental", (which does make qmake && make).

Target.pri was touched though, so qmake was (should be) run on that, but there might be nother dep that was not picked up due to a missing root make qmake.

[Csaba Osztrogonác]

*** Bug 93580 has been marked as a duplicate of this bug. ***

[Csaba Osztrogonác]

*** Bug 93582 has been marked as a duplicate of this bug. ***

[Csaba Osztrogonác]

I'm picked it up.

[Csaba Osztrogonác]

Created attachment 157407 [details]
Patch

[Csaba Osztrogonác]

Comment on attachment 157407 [details]
Patch

landed in https://trac.webkit.org/changeset/125163