Don't re-use the same EventDispatcher instance to dispatch events.

• Component: UI Events
• Status: RESOLVED FIXED

[Hayato Ito]

Three are some member functions in EventDispatcher, which assume the instance of EventDispatcher is used for only one event.

Example:
- EventDispatcher::ensureEventAncestor calculates ancestors of node. But once the calculation is done, it never recalculates. The result of the calculation depends on the given event's type().

So it is potentially dangerous to call EventDispatcher::dispatchEvent(Event) twice with different events against the same EventDispatcher instance.
We have to make sure the EventDspatcher instance is used only once per event. Currently dispatching 'dblclick' event violates this rule.

[Hayato Ito]

Created attachment 156868 [details]
Fix dblclick event and add ASSERT

[Dimitri Glazkov (Google)]

Comment on attachment 156868 [details]
Fix dblclick event and add ASSERT

ok

[WebKit Review Bot]

Comment on attachment 156868 [details]
Fix dblclick event and add ASSERT

Clearing flags on attachment: 156868

Committed r124975: <http://trac.webkit.org/changeset/124975>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Darin Adler]

Comment on attachment 156868 [details]
Fix dblclick event and add ASSERT

View in context: https://bugs.webkit.org/attachment.cgi?id=156868&action=review

> Source/WebCore/dom/MouseEvent.cpp:-218
> -        doubleClickEvent->initMouseEvent(eventNames().dblclickEvent, event()->bubbles(), event()->cancelable(), event()->view(),
> -                event()->detail(), event()->screenX(), event()->screenY(), event()->clientX(), event()->clientY(),
> -                event()->ctrlKey(), event()->altKey(), event()->shiftKey(), event()->metaKey(),
> -                event()->button(), relatedTarget);

This is the correct formatting for a multiple line function call in the WebKit coding style.

> Source/WebCore/dom/MouseEvent.cpp:219
> +    doubleClickEvent->initMouseEvent(eventNames().dblclickEvent, event()->bubbles(), event()->cancelable(), event()->view(),
> +                                     event()->detail(), event()->screenX(), event()->screenY(), event()->clientX(), event()->clientY(),
> +                                     event()->ctrlKey(), event()->altKey(), event()->shiftKey(), event()->metaKey(),
> +                                     event()->button(), relatedTarget);

Whereas this is incorrect.

[Hayato Ito]

Oh. Nice catch. Thank you.
I think WebKit doesn't like a patch which only fixes style. So I'll fix it if i have a chance later.

(In reply to comment #5)
> (From update of attachment 156868 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=156868&action=review
> 
> > Source/WebCore/dom/MouseEvent.cpp:-218
> > -        doubleClickEvent->initMouseEvent(eventNames().dblclickEvent, event()->bubbles(), event()->cancelable(), event()->view(),
> > -                event()->detail(), event()->screenX(), event()->screenY(), event()->clientX(), event()->clientY(),
> > -                event()->ctrlKey(), event()->altKey(), event()->shiftKey(), event()->metaKey(),
> > -                event()->button(), relatedTarget);
> 
> This is the correct formatting for a multiple line function call in the WebKit coding style.
> 
> > Source/WebCore/dom/MouseEvent.cpp:219
> > +    doubleClickEvent->initMouseEvent(eventNames().dblclickEvent, event()->bubbles(), event()->cancelable(), event()->view(),
> > +                                     event()->detail(), event()->screenX(), event()->screenY(), event()->clientX(), event()->clientY(),
> > +                                     event()->ctrlKey(), event()->altKey(), event()->shiftKey(), event()->metaKey(),
> > +                                     event()->button(), relatedTarget);
> 
> Whereas this is incorrect.