Summary: | Web Inspector: a tiny refactoring of Highlighter in InspectorDOMAgent | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Sergey Rogulenko <rogulenko> | ||||||||||
Component: | Web Inspector (Deprecated) | Assignee: | Nobody <webkit-unassigned> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys | ||||||||||
Priority: | P2 | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | All | ||||||||||||
OS: | All | ||||||||||||
Attachments: |
|
Description
Sergey Rogulenko
2012-08-06 04:37:11 PDT
Created attachment 156659 [details]
Patch
Created attachment 156662 [details]
Patch
Comment on attachment 156662 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=156662&action=review > Source/WebCore/inspector/InspectorDOMAgent.cpp:1008 > + m_inspectModeHighlightConfig = highlightConfigFromInspectorObject(errorString, highlightInspectorObject); You should return early in case of error. > Source/WebCore/inspector/InspectorDOMAgent.cpp:1054 > + if (highlightConfig) ditto. Created attachment 156668 [details]
Patch
Comment on attachment 156668 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=156668&action=review > Source/WebCore/inspector/InspectorDOMAgent.cpp:1013 > hideHighlight(&error); You wanted to pass errorString there. Created attachment 156669 [details]
Patch
Comment on attachment 156669 [details] Patch Clearing flags on attachment: 156669 Committed r124769: <http://trac.webkit.org/changeset/124769> All reviewed patches have been landed. Closing bug. |