Bug 93257

Summary: Web Inspector: a tiny refactoring of Highlighter in InspectorDOMAgent
Product: WebKit Reporter: Sergey Rogulenko <rogulenko>
Component: Web Inspector (Deprecated)Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Description Sergey Rogulenko 2012-08-06 04:37:11 PDT
A tiny refactoring of Highlighter in InspectorDOMAgent.
Comment 1 Sergey Rogulenko 2012-08-06 04:42:15 PDT
Created attachment 156659 [details]
Patch
Comment 2 Sergey Rogulenko 2012-08-06 04:52:31 PDT
Created attachment 156662 [details]
Patch
Comment 3 Pavel Feldman 2012-08-06 05:08:35 PDT
Comment on attachment 156662 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=156662&action=review

> Source/WebCore/inspector/InspectorDOMAgent.cpp:1008
> +        m_inspectModeHighlightConfig = highlightConfigFromInspectorObject(errorString, highlightInspectorObject);

You should return early in case of error.

> Source/WebCore/inspector/InspectorDOMAgent.cpp:1054
> +        if (highlightConfig)

ditto.
Comment 4 Sergey Rogulenko 2012-08-06 05:29:29 PDT
Created attachment 156668 [details]
Patch
Comment 5 Pavel Feldman 2012-08-06 05:33:21 PDT
Comment on attachment 156668 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=156668&action=review

> Source/WebCore/inspector/InspectorDOMAgent.cpp:1013
>          hideHighlight(&error);

You wanted to pass errorString there.
Comment 6 Sergey Rogulenko 2012-08-06 05:34:16 PDT
Created attachment 156669 [details]
Patch
Comment 7 WebKit Review Bot 2012-08-06 07:14:40 PDT
Comment on attachment 156669 [details]
Patch

Clearing flags on attachment: 156669

Committed r124769: <http://trac.webkit.org/changeset/124769>
Comment 8 WebKit Review Bot 2012-08-06 07:14:45 PDT
All reviewed patches have been landed.  Closing bug.