Bug 93230

Summary: [BlackBerry] We should fail the HTTP authentication silently for sub-resources.
Product: WebKit Reporter: Charles Wei <charles.wei>
Component: WebKit BlackBerryAssignee: George Staikos <staikos>
Status: RESOLVED FIXED    
Severity: Major CC: joenotcharles, mifenton, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
staikos: review-
New approach none

Charles Wei
Reported 2012-08-06 00:58:37 PDT
We should fail the HTTP authentication silently for sub-resources instead of prompting the user for credentials. Internal PR: 160859. There's another upstreaming Bug: https://bugs.webkit.org/show_bug.cgi?id=91964 which tries to introduce an "webkitBackgroundRequest" attribute to make XHR fail silently, but that idea is not approved. The right solution is just fail silently unconditionally for sub-resources.
Attachments
Patch (1.89 KB, patch)
2012-08-06 01:05 PDT, Charles Wei 		staikos: review-
DetailsFormatted DiffDiff
New approach (1.62 KB, patch)
2012-08-06 12:22 PDT, George Staikos 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Charles Wei
Comment 1 2012-08-06 01:05:49 PDT
Created attachment 156614 [details] Patch
George Staikos
Comment 2 2012-08-06 11:03:21 PDT
Comment on attachment 156614 [details] Patch Determined in offline discussion that this is a bit dangerous to do just yet.
George Staikos
Comment 3 2012-08-06 12:22:24 PDT
Created attachment 156742 [details] New approach
Joe Mason
Comment 4 2012-08-06 14:08:16 PDT
Comment on attachment 156742 [details] New approach LGTM
George Staikos
Comment 5 2012-08-07 05:55:34 PDT
(In reply to comment #4) > (From update of attachment 156742 [details]) > LGTM Based on our offline discussion, do you still believe so?
Joe Mason
Comment 6 2012-08-07 07:03:58 PDT
(In reply to comment #5) > (In reply to comment #4) > > (From update of attachment 156742 [details] [details]) > > LGTM > > Based on our offline discussion, do you still believe so? Yep.
Rob Buis
Comment 7 2012-08-07 08:05:50 PDT
Comment on attachment 156742 [details] New approach Ok.
WebKit Review Bot
Comment 8 2012-08-07 09:02:22 PDT
Comment on attachment 156742 [details] New approach Clearing flags on attachment: 156742 Committed r124894: <http://trac.webkit.org/changeset/124894>
WebKit Review Bot
Comment 9 2012-08-07 09:02:26 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.