Bug 93230

Summary: [BlackBerry] We should fail the HTTP authentication silently for sub-resources.
Product: WebKit Reporter: Charles Wei <charles.wei>
Component: WebKit BlackBerryAssignee: George Staikos <staikos>
Status: RESOLVED FIXED    
Severity: Major CC: joenotcharles, mifenton, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
staikos: review-
New approach none

Description Charles Wei 2012-08-06 00:58:37 PDT 
We should fail the HTTP authentication silently for sub-resources instead of prompting the user for credentials.  Internal PR: 160859.

There's another upstreaming Bug: https://bugs.webkit.org/show_bug.cgi?id=91964 which tries to introduce an "webkitBackgroundRequest" attribute to make XHR fail silently, but that idea is not approved. The right solution is just fail silently unconditionally for sub-resources.
Comment 1 Charles Wei 2012-08-06 01:05:49 PDT 
Created attachment 156614 [details]
Patch
Comment 2 George Staikos 2012-08-06 11:03:21 PDT 
Comment on attachment 156614 [details]
Patch

Determined in offline discussion that this is a bit dangerous to do just yet.
Comment 3 George Staikos 2012-08-06 12:22:24 PDT 
Created attachment 156742 [details]
New approach
Comment 4 Joe Mason 2012-08-06 14:08:16 PDT 
Comment on attachment 156742 [details]
New approach

LGTM
Comment 5 George Staikos 2012-08-07 05:55:34 PDT 
(In reply to comment #4)
> (From update of attachment 156742 [details])
> LGTM

Based on our offline discussion, do you still believe so?
Comment 6 Joe Mason 2012-08-07 07:03:58 PDT 
(In reply to comment #5)
> (In reply to comment #4)
> > (From update of attachment 156742 [details] [details])
> > LGTM
> 
> Based on our offline discussion, do you still believe so?

Yep.
Comment 7 Rob Buis 2012-08-07 08:05:50 PDT 
Comment on attachment 156742 [details]
New approach

Ok.
Comment 8 WebKit Review Bot 2012-08-07 09:02:22 PDT 
Comment on attachment 156742 [details]
New approach

Clearing flags on attachment: 156742

Committed r124894: <http://trac.webkit.org/changeset/124894>
Comment 9 WebKit Review Bot 2012-08-07 09:02:26 PDT 
All reviewed patches have been landed.  Closing bug.