Bug 93186 – [Chromium Mac] Tests are exiting early due to failures to load missingImage.png

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Ryosuke Niwa]

Chromium Mac bots on build.webkit.org are exiting early in nrwt due to the following error:

crash log for DumpRenderTree (pid 40443):
STDOUT: <empty>
STDERR: [40443:-1607707328:21417332728962:FATAL:platform_support_mac.mm(215)] Failed reading: /Users/rniwa/webkit2/Source/WebKit/chromium/xcodebuild/Release/DumpRenderTree.app/Contents/MacOS/../Resources/missingImage.png

This started sometime in the last 2-3 weeks and I can reproduce it locally as well.
Since this is not happening on chromium bots (onces on build.chromium.org), I'd assume this is some sort of gyp problem.

[Nico Weber]

Likely caused by http://trac.webkit.org/changeset/123668 . The right fix is to load missingImage.png through the resourcebundle api instead of through the bundle image cache. See also http://crbug.com/136118 which is somewhat related.

(I'll take a short look now.)

[Nico Weber]

Actually Tools/DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp still lists that image. So probably not caused by 123668.

[Nico Weber]

I have something that seems to help, but I'm not sure how this could've ever worked before.

rniwa: Can you try patching in https://chromiumcodereview.appspot.com/10852021 in your chromium deps, and also the following patch to your webkit tree (copy it to your clipboard, then run `pbpaste | patch -p1` in your webkit root directory) and tell me if this fixes things for you?

diff --git a/Tools/DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp b/Tools/DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp
index 5555e44..b6e9420 100644
--- a/Tools/DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp
+++ b/Tools/DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp
@@ -226,6 +226,7 @@
                         '<(tools_dir)/DumpRenderTree/fonts/WebKitWeightWatcher700.ttf',
                         '<(tools_dir)/DumpRenderTree/fonts/WebKitWeightWatcher800.ttf',
                         '<(tools_dir)/DumpRenderTree/fonts/WebKitWeightWatcher900.ttf',
+                        '<(SHARED_INTERMEDIATE_DIR)/webkit/missingImage.png',
                         '<(SHARED_INTERMEDIATE_DIR)/webkit/textAreaResizeCorner.png',
                     ],
                 },{ # OS!="mac"

[Ryosuke Niwa]

Thanks for the investigation! It didn't work as far as I've tried incremental building. I'm doing a clean build now.

[Nico Weber]

You need to re-run gyp if you haven't.

[Ryosuke Niwa]

(In reply to comment #5)
> You need to re-run gyp if you haven't.

Ah! Right. It works :)

[Nico Weber]

Cool! I sent the chromium part out for review, and will attach the webkit part to this bug once the chromium part is in.

[Nico Weber]

Created attachment 156542 [details]
Patch

[WebKit Review Bot]

Comment on attachment 156542 [details]
Patch

Clearing flags on attachment: 156542

Committed r124712: <http://trac.webkit.org/changeset/124712>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Florin Malita]

I assume it just exposed an existing bug, but after this patch Dromaeo/jslib-modify-jquery.html is crashing: http://build.webkit.org/builders/Chromium%20Mac%20Release%20%28Perf%29/builds/4909/steps/perf-test/logs/stdio



Running Dromaeo/jslib-modify-jquery.html (53 of 100)
unexpected EOF of stdout
unexpected EOF of stderr
error: Dromaeo/jslib-modify-jquery.html
DumpRenderTree(94151,0xac0ba2c0) malloc: *** mmap(size=8388608) failed (error code=12)
*** error: can't allocate region securely
*** set a breakpoint in malloc_error_break to debug
1   0xcd9b8b
2   0x125068f
3   0x1241d18
4   0x133caad
5   0x133cb33
6   0x127404b
7   0x127577e
8   0x127772e
9   0x1275d54
10  0x127ca7c
11  0x12560d3
12  0x1255598
13  0x125d211
14  0x1257dc1
15  0x12560f4
16  0x1255598
17  0x125d211
18  0x1257dc1
19  0x12560f4
20  0x1255598
21  0x125d211
22  0x1257dc1
23  0x12560f4
24  0x1255598
25  0x125d211
26  0x1257dc1
27  0x12560f4
28  0x1255598
29  0x134ed06
30  0x11c18ff
31  0x11bf489
	0   DumpRenderTree                      0x003a00aa DumpRenderTree + 3715242
	1   DumpRenderTree                      0x003c1401 DumpRenderTree + 3851265
	2   libsystem_c.dylib                   0x9158d59b _sigtramp + 43
	3   ???                                 0xffffffff 0x0 + 4294967295
	4   DumpRenderTree                      0x00cd9b8b DumpRenderTree + 13388683
	5   DumpRenderTree                      0x0125068f DumpRenderTree + 19117711
	6   DumpRenderTree                      0x01241d18 DumpRenderTree + 19057944
	7   DumpRenderTree                      0x0133caad DumpRenderTree + 20085421
	8   DumpRenderTree                      0x0133cb33 DumpRenderTree + 20085555
	9   DumpRenderTree                      0x0127404b DumpRenderTree + 19263563
	10  DumpRenderTree                      0x0127577e DumpRenderTree + 19269502
	11  DumpRenderTree                      0x0127772e DumpRenderTree + 19277614
	12  DumpRenderTree                      0x01275d54 DumpRenderTree + 19270996
	13  DumpRenderTree                      0x0127ca7c DumpRenderTree + 19298940
	14  DumpRenderTree                      0x012560d3 DumpRenderTree + 19140819
	15  DumpRenderTree                      0x01255598 DumpRenderTree + 19137944
	16  DumpRenderTree                      0x0125d211 DumpRenderTree + 19169809
	17  DumpRenderTree                      0x01257dc1 DumpRenderTree + 19148225
	18  DumpRenderTree                      0x012560f4 DumpRenderTree + 19140852
	19  DumpRenderTree                      0x01255598 DumpRenderTree + 19137944
	20  DumpRenderTree                      0x0125d211 DumpRenderTree + 19169809
	21  DumpRenderTree                      0x01257dc1 DumpRenderTree + 19148225
	22  DumpRenderTree                      0x012560f4 DumpRenderTree + 19140852
	23  DumpRenderTree                      0x01255598 DumpRenderTree + 19137944
	24  DumpRenderTree                      0x0125d211 DumpRenderTree + 19169809
	25  DumpRenderTree                      0x01257dc1 DumpRenderTree + 19148225
	26  DumpRenderTree                      0x012560f4 DumpRenderTree + 19140852
	27  DumpRenderTree                      0x01255598 DumpRenderTree + 19137944
	28  DumpRenderTree                      0x0125d211 DumpRenderTree + 19169809
	29  DumpRenderTree                      0x01257dc1 DumpRenderTree + 19148225
	30  DumpRenderTree                      0x012560f4 DumpRenderTree + 19140852
	31  DumpRenderTree                      0x01255598 DumpRenderTree + 19137944
	32  DumpRenderTree                      0x0134ed06 DumpRenderTree + 20159750
	33  DumpRenderTree                      0x011c18ff DumpRenderTree + 18532607
	34  DumpRenderTree                      0x011bf489 DumpRenderTree + 18523273
	35  DumpRenderTree                      0x011c9e57 DumpRenderTree + 18566743
	36  DumpRenderTree                      0x00cf4c2c DumpRenderTree + 13499436
	37  DumpRenderTree                      0x00cf4b06 DumpRenderTree + 13499142
	38  DumpRenderTree                      0x017ad731 DumpRenderTree + 24741681
	39  DumpRenderTree                      0x003d228a DumpRenderTree + 3920522
	40  DumpRenderTree                      0x003d22c6 DumpRenderTree + 3920582
	41  DumpRenderTree                      0x003d23c1 DumpRenderTree + 3920833
	42  DumpRenderTree                      0x003b293d DumpRenderTree + 3791165
	43  DumpRenderTree                      0x003b2d22 DumpRenderTree + 3792162
	44  DumpRenderTree                      0x00399195 DumpRenderTree + 3686805
	45  CoreFoundation                      0x9040513f __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ + 15
	46  CoreFoundation                      0x90404af6 __CFRunLoopDoSources0 + 246
	47  CoreFoundation                      0x9042e9c8 __CFRunLoopRun + 1112
	48  CoreFoundation                      0x9042e1dc CFRunLoopRunSpecific + 332
	49  CoreFoundation                      0x9042e088 CFRunLoopRunInMode + 120
	50  HIToolbox                           0x9bf4c723 RunCurrentEventLoopInMode + 318
	51  HIToolbox                           0x9bf53a8b ReceiveNextEventCommon + 381
	52  HIToolbox                           0x9bf538fa BlockUntilNextEventMatchingListInMode + 88
	53  AppKit                              0x978740d8 _DPSNextEvent + 678
	54  AppKit                              0x97873942 -[NSApplication nextEventMatchingMask:untilDate:inMode:dequeue:] + 113
	55  AppKit                              0x9786fcb1 -[NSApplication run] + 911
	56  DumpRenderTree                      0x003995b7 DumpRenderTree + 3687863
	57  DumpRenderTree                      0x0039908c DumpRenderTree + 3686540
	58  DumpRenderTree                      0x003b239f DumpRenderTree + 3789727
	59  DumpRenderTree                      0x003c243e DumpRenderTree + 3855422
	60  DumpRenderTree                      0x003b1b9a DumpRenderTree + 3787674
	61  DumpRenderTree                      0x0017be33 DumpRenderTree + 1470003
ax: 0, bx: 1003, cx: 2860, dx: 1e00
di: 34, si: 6c198410, bp: c000fa98, sp: c000fa90, ss: 23, flags: 10246
ip: c7dd4, cs: 1b, ds: 23, es: 23, fs: 0, gs: f

FAILED

[Nico Weber]

comment 11: Can you file a new bug for that?