Summary: | REGRESSION: crash in HTML tokenizer at Japanese Apple support page | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Rachael Worthington (cheers) <rachael> | ||||||||
Component: | WebCore Misc. | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | ap, len, mitz | ||||||||
Priority: | P1 | Keywords: | InRadar, NeedsReduction, Regression | ||||||||
Version: | 420+ | ||||||||||
Hardware: | Mac | ||||||||||
OS: | OS X 10.4 | ||||||||||
URL: | http://apple.com/jp/support/ | ||||||||||
Attachments: |
|
Description
Rachael Worthington (cheers)
2006-06-05 11:53:44 PDT
This is a regression relative to the last released Safari. Marking as such and upgrading to P1. Debug build gets an assertion failure: ASSERTION FAILED: !scriptNode (/Users/ap/WebKit/WebCore/html/HTMLTokenizer.cpp:1166 WebCore::HTMLTokenizer::State WebCore::HTMLTokenizer::parseTag(WebCore::SegmentedString&, WebCore::HTMLTokenizer::State)) There seem to be two halves to this crash. Half the problem is a crash with script nesting. I've created a much-reduced test case that demonstrates this. The other half of the problem seems to be a yen character mixup, where a \ is being used to escape the / in </script> -- the \ looks like a yen character and I think it might not be working properly. The reduced test case does not address that. Once the crash is fixed we need to look at the page again and make sure the JavaScript is being loaded properly. Created attachment 8749 [details]
greatly reduced test case
(In reply to comment #4) > There seem to be two halves to this crash. > > Half the problem is a crash with script nesting. I've created a much-reduced > test case that demonstrates this. That would be bug 9554. Not closing this as a duplicate, but it's the second half that needs to be reduced. Created attachment 9050 [details] Patch for the crashing half This fixes the crash and behaves correctly with the test case from bug 9554. It also passes all the layout tests. I haven't done much testing beyond that (in particular, with external scripts, cached and uncached). Comment on attachment 9050 [details]
Patch for the crashing half
looks good, please add test case and changelog
Created attachment 9061 [details]
Patch for the crashing half, now with changelog and test
Comment on attachment 9061 [details]
Patch for the crashing half, now with changelog and test
r=me
Committed revision 15075. |