Bug 93142

Summary: noteOff can be called more than once when source is looping
Product: WebKit Reporter: Raymond Toy <rtoy>
Component: Web AudioAssignee: Raymond Toy <rtoy>
Status: NEW    
Severity: Normal CC: crogers, dglazkov, eric.carlson, feature-media-reviews, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
URL: https://www.corp.google.com/~rtoy/bugs/webkit/noteoff-loop-bug.html
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from gce-cr-linux-08
none
Patch none

Raymond Toy
Reported 2012-08-03 10:50:03 PDT
According to the webaudio spec, noteOn and noteOff should only be called once, but as the URL link shows, noteOff can be called many times, and it appears that the last noteOff is the one that is used. I think the first noteOff should be the one to take effect. (But perhaps this undefined behavior since the spec says only one call to noteOff is allowed.) This only happens when the source is looping. If the source is not looping, then the first noteOff takes affect; additional noteOff events do nothing.
Attachments
Patch (7.31 KB, patch)
2012-08-09 10:42 PDT, Raymond Toy 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from gce-cr-linux-08 (417.04 KB, application/zip)
2012-08-09 12:40 PDT, WebKit Review Bot 		no flags
Details
Patch (8.04 KB, patch)
2012-08-09 12:48 PDT, Raymond Toy 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Raymond Toy
Comment 1 2012-08-09 10:42:45 PDT
Created attachment 157485 [details] Patch
WebKit Review Bot
Comment 2 2012-08-09 12:40:21 PDT
Comment on attachment 157485 [details] Patch Attachment 157485 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13457923 New failing tests: webaudio/audiobuffersource-looping-noteoff.html
WebKit Review Bot
Comment 3 2012-08-09 12:40:24 PDT
Created attachment 157517 [details] Archive of layout-test-results from gce-cr-linux-08 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: gce-cr-linux-08 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid
Raymond Toy
Comment 4 2012-08-09 12:48:49 PDT
Created attachment 157519 [details] Patch
Anders Carlsson
Comment 5 2014-02-05 11:11:27 PST
Comment on attachment 157519 [details] Patch Clearing review flag on patches from before 2014. If this patch is still relevant, please reset the r? flag.
Note You need to log in before you can comment on or make changes to this bug.