Bug 93133 – Web Inspector: Clarify what Settings features require the tools to be open

• Component: Web Inspector (Deprecated)
• Status: RESOLVED INVALID

[Addy Osmani]

At present, users are unware of what features require the Inspector/DevTools to be open in order to function. These include 'Disable cache', 'Disable JavaScript' and so on. Ideally we should add a star next to features that require this and place a short note at the top of the relevant tab(s) letting users know they need to be open.

[Addy Osmani]

Created attachment 156412 [details]
Patch

[Andrey Kosyakov]

Comment on attachment 156412 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=156412&action=review

> Source/WebCore/English.lproj/localizedStrings.js:648
> +localizedStrings["* Requires Developer Tools to be open."] = "* Requires Developer Tools to be open.";

We can't use vendor specific product names in WebCore -- this would have to be "Web Inspector". See WebInspector.clipboardAccessDeniedMessage (http://trac.webkit.org/browser/trunk/Source/WebKit/chromium/src/js/DevTools.js#L59) for an example of how we used to address this.
I think we may want to generalize it to a function that either returns a product name or maps a message to a vendor-specific string. Pavel, WDYT?
Also, I would change the wording to "Only effective while {product name} is open".

> Source/WebCore/inspector/front-end/SettingsScreen.js:402
> +    _createOnlyWhileOpenWarningSubsection: function()
> +    {
> +        var subsection = document.createElement("div");
> +        var warning = subsection.createChild("span", "settings-experiments-warning-subsection-warning");
> +        warning.textContent = WebInspector.UIString("WARNING:");
> +        subsection.appendChild(document.createTextNode(" "));
> +        var message = subsection.createChild("span", "settings-experiments-warning-subsection-message");
> +        message.textContent = WebInspector.UIString("* Requires Developer Tools to be open.");
> +        return subsection;
> +    },

Can we generalize _createExperimentsWarningSubsection() instead so that it creates warnings with arbitrary text?

[Addy Osmani]

> We can't use vendor specific product names in WebCore -- this would have to be "Web Inspector". See WebInspector.clipboardAccessDeniedMessage (http://trac.webkit.org/browser/trunk/Source/WebKit/chromium/src/js/DevTools.js#L59) for an example of how we used to address this.
> I think we may want to generalize it to a function that either returns a product name or maps a message to a vendor-specific string. Pavel, WDYT?
> Also, I would change the wording to "Only effective while {product name} is open".

Agree on both counts. I'll update this.

> 
> > Source/WebCore/inspector/front-end/SettingsScreen.js:402
> > +    _createOnlyWhileOpenWarningSubsection: function()
> > +    {
> > +        var subsection = document.createElement("div");
> > +        var warning = subsection.createChild("span", "settings-experiments-warning-subsection-warning");
> > +        warning.textContent = WebInspector.UIString("WARNING:");
> > +        subsection.appendChild(document.createTextNode(" "));
> > +        var message = subsection.createChild("span", "settings-experiments-warning-subsection-message");
> > +        message.textContent = WebInspector.UIString("* Requires Developer Tools to be open.");
> > +        return subsection;
> > +    },
> 
> Can we generalize _createExperimentsWarningSubsection() instead so that it creates warnings with arbitrary text?

Absolutely. There's no need for replication when we can generalize it. I'll wait to see what Pavel thinks about the warning message before updating the patch.

[Pavel Feldman]

> Also, I would change the wording to "Only effective while {product name} is open".

Sounds good to me. We could add WebInspector.productName() into the UIUtils.js and override it in the DevTools.js under WebKit/chromium/src/js/ to keep things simple.

[Pavel Feldman]

Comment on attachment 156412 [details]
Patch

r- per Andrey's comments.

[Brian Burg]

Closing as invalid, as this bug pertains to the old inspector UI and/or its tests.
Please file a new bug (https://www.webkit.org/new-inspector-bug) if the bug/feature/issue is still relevant to WebKit trunk.