Bug 93132

Summary: Fix a check for key location in input event conversion
Product: WebKit Reporter: Sailesh Agrawal <sail>
Component: WebCore Misc.Assignee: Sailesh Agrawal <sail>
Status: RESOLVED DUPLICATE    
Severity: Normal CC: abarth, ap, raymes
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch abarth: review-

Sailesh Agrawal
Reported 2012-08-03 09:40:18 PDT
Fix a check for key location in input event conversion
Attachments
Patch (1.50 KB, patch)
2012-08-03 09:49 PDT, Raymes Khoury 		abarth: review-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Raymes Khoury
Comment 1 2012-08-03 09:49:02 PDT
Created attachment 156401 [details] Patch
Adam Barth
Comment 2 2012-08-03 10:21:32 PDT
Comment on attachment 156401 [details] Patch The ChangeLog doesn't give any idea what bug you're trying to fix or why you're making this change. Also we'll need a test so we don't screw this up in the future. Perhaps a LayoutTest that uses EventSender?
Raymes Khoury
Comment 3 2012-08-28 10:21:48 PDT
How might I go about testing this? I don't think this can be tested purely as a layout test (though I might be wrong). This code handles cases where an event passes through WebKit and back into Chromium code and is converted from a KeyboardEvent back into a WebInputEvent. An example of this situation is for plugins which handle input events. Thanks.
Adam Barth
Comment 4 2012-08-28 15:28:22 PDT
Perhaps a unit test in http://trac.webkit.org/browser/trunk/Source/WebKit/chromium/tests/WebFrameTest.cpp ?
Adam Barth
Comment 5 2012-08-28 15:30:08 PDT
Actually, I think you should just be able to unit test WebKeyboardEventBuilder directly. It's exposed in the API and WebKit unit tests can see the WEBKIT_IMPLEMENTATION parts of the API.
Raymes Khoury
Comment 6 2012-09-05 15:46:09 PDT
Fix and test added in https://bugs.webkit.org/show_bug.cgi?id=94142 *** This bug has been marked as a duplicate of bug 94142 ***
Note You need to log in before you can comment on or make changes to this bug.